> On 2008-08-20 06:32:27, Aaron Seigo wrote: > > it looks fine; my only question/concern is whether we have a user for it > > yet? this one should be easy to find a user for, actually, but i'd like to > > hold off on things like tables until there are actual widgets wanting to > > use it so we don't end up with tons of widgets in libplasma, only some of > > which are used.
yes, the weather applet, also amarok guys asked for it. will put this one and ask to amarok folks if this is enough or if they wants also a list view actually for a straight list a treeview is ok, what could be useful is an icon view (thinking about the small form factor menu) for that one could be used a generalization of the folderview? (me a bit scared of that code) - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/138/#review126 ----------------------------------------------------------- On 2008-08-19 11:26:07, Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/138/ > ----------------------------------------------------------- > > (Updated 2008-08-19 11:26:07) > > > Review request for Plasma. > > > Summary > ------- > > This is a proxy widget to a QTreeView, it has the usual plasma widgets > functions and uses the new scrollbar. > Since the scrollbar is private it's needed to be in libplasma to use it, so i > would make also the other views like a listview and maybe a table beyond this. > not sure if make the view transparent since the delegate provided by plasma > is not adapt to have a black background, so maybe not. > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/libs/plasma/widgets/treeview.cpp > /trunk/KDE/kdebase/workspace/libs/plasma/CMakeLists.txt > /trunk/KDE/kdebase/workspace/libs/plasma/widgets/treeview.h > > Diff: http://reviewboard.vidsolbach.de/r/138/diff > > > Testing > ------- > > > Thanks, > > Marco > > _______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
