Your message dated Tue, 01 Apr 2025 10:21:46 +0000
with message-id <[email protected]>
and subject line Bug#1101804: fixed in rtpengine 12.5.1.27-2
has caused the Debian Bug report #1101804,
regarding rtpengine-kernel-dkms: dkms updates
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1101804: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1101804
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: rtpengine-kernel-dkms
Version: 12.5.1.27-1
Severity: normal
Tags: patch
Hi,
here are a few updates for the -dkms package.
The first patch sets BUILD_EXCLUSIVE_KERNEL_MIN in dkms.conf to clearly
document the oldest supported kernel version. This is mostly interesting
for QA.
The next solves the asymmetry between postinst and prerm - prerm needs
to apply the same container checks as postinst and avoid affecting the
host kernel.
The last patch fixes building twice in a row by removing a new generated
file. That should probably be better fixed in the upsteam build system.
Andreas
>From 30fd3d55a1d8bfbf6f53ca81a97a8677d1c893fe Mon Sep 17 00:00:00 2001
From: Andreas Beckmann <[email protected]>
Date: Mon, 31 Mar 2025 11:15:46 +0200
Subject: [PATCH 1/3] dkms.conf: declare BUILD_EXCLUSIVE_KERNEL_MIN="5.1"
---
debian/rtpengine-kernel-dkms.dkms | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/debian/rtpengine-kernel-dkms.dkms
b/debian/rtpengine-kernel-dkms.dkms
index d3584f3..d6cd94d 100644
--- a/debian/rtpengine-kernel-dkms.dkms
+++ b/debian/rtpengine-kernel-dkms.dkms
@@ -1,5 +1,9 @@
PACKAGE_NAME="rtpengine"
PACKAGE_VERSION="#MODULE_VERSION#"
+
+# the static_assert() macro was introduced in Linux v5.1
+BUILD_EXCLUSIVE_KERNEL_MIN="5.1"
+
MAKE[0]="make -C ${kernel_source_dir}
M=${dkms_tree}/${PACKAGE_NAME}/${PACKAGE_VERSION}/build
RTPENGINE_VERSION=\"${PACKAGE_VERSION}\""
CLEAN="make -C ${kernel_source_dir}
M=${dkms_tree}/${PACKAGE_NAME}/${PACKAGE_VERSION}/build clean"
AUTOINSTALL=yes
--
2.39.5
>From d997be78caf0ce54ff35b6e078cf361b81fa05e7 Mon Sep 17 00:00:00 2001
From: Andreas Beckmann <[email protected]>
Date: Mon, 31 Mar 2025 11:26:28 +0200
Subject: [PATCH 2/3] dkms.prerm: do not act on daemon or module in a container
environment
in a container
- the daemon is not started by rtpengine-kernel-dkms.postinst
- do not attempt to unload a module from the host kernel
---
debian/rtpengine-kernel-dkms.postinst | 2 +-
debian/rtpengine-kernel-dkms.prerm | 18 +++++++++++++++---
2 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/debian/rtpengine-kernel-dkms.postinst
b/debian/rtpengine-kernel-dkms.postinst
index 8c2a4a6..3ef0291 100644
--- a/debian/rtpengine-kernel-dkms.postinst
+++ b/debian/rtpengine-kernel-dkms.postinst
@@ -11,7 +11,7 @@ fi
#DEBHELPER#
if [ "$VIRT" = "yes" ]; then
- echo "Container environment detected. Skip dkms"
+ echo "Container environment detected. Skip daemon"
else
if [ "$1" = 'configure' ] ; then
# try to start the daemon
diff --git a/debian/rtpengine-kernel-dkms.prerm
b/debian/rtpengine-kernel-dkms.prerm
index d8b87cc..ea85072 100644
--- a/debian/rtpengine-kernel-dkms.prerm
+++ b/debian/rtpengine-kernel-dkms.prerm
@@ -2,9 +2,21 @@
set -e
-# make sure it's not running
-service rtpengine-daemon stop || true
-rmmod "xt_RTPENGINE" 2>/dev/null || true
+if [ -x "$(command -v ngcp-virt-identify)" ]; then
+ if ngcp-virt-identify --type container; then
+ VIRT="yes"
+ fi
+fi
+
+if [ "$VIRT" = "yes" ]; then
+ echo "Container environment detected. Skip daemon"
+else
+ # make sure it's not running
+ if [ -x /etc/init.d/rtpengine-daemon ] ; then
+ invoke-rc.d rtpengine-daemon stop || true
+ fi
+ rmmod "xt_RTPENGINE" 2>/dev/null || true
+fi
#DEBHELPER#
--
2.39.5
>From ebdd6d84d49150d01ac911d21b3e33c9dd3e6c3b Mon Sep 17 00:00:00 2001
From: Andreas Beckmann <[email protected]>
Date: Mon, 31 Mar 2025 11:57:56 +0200
Subject: [PATCH 3/3] fix building twice in a row
clean the generated file lib/codeclib.strhash.c
---
debian/clean | 1 +
1 file changed, 1 insertion(+)
diff --git a/debian/clean b/debian/clean
index 934cc47..1bebea6 100644
--- a/debian/clean
+++ b/debian/clean
@@ -1,2 +1,3 @@
debian/README.html.gz
debian/README.md.gz
+lib/codeclib.strhash.c
--
2.39.5
--- End Message ---
--- Begin Message ---
Source: rtpengine
Source-Version: 12.5.1.27-2
Done: Victor Seva <[email protected]>
We believe that the bug you reported is fixed in the latest version of
rtpengine, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Victor Seva <[email protected]> (supplier of updated rtpengine package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 01 Apr 2025 11:54:44 +0200
Source: rtpengine
Architecture: source
Version: 12.5.1.27-2
Distribution: unstable
Urgency: medium
Maintainer: Debian VoIP Team <[email protected]>
Changed-By: Victor Seva <[email protected]>
Closes: 1101804
Changes:
rtpengine (12.5.1.27-2) unstable; urgency=medium
.
[ Andreas Beckmann ] (Closes: #1101804)
* dkms.conf: declare BUILD_EXCLUSIVE_KERNEL_MIN="5.1"
* dkms.prerm: do not act on daemon or module in a container environment
* fix building twice in a row
Checksums-Sha1:
f24fc2331a694967b5042bd207a7bd6866fff016 3039 rtpengine_12.5.1.27-2.dsc
7d03206ecb38a81d3306f3c5b0c504e72a9ce205 14668
rtpengine_12.5.1.27-2.debian.tar.xz
848f58fb45ec5d44113f1e9958aa805d3c10b185 18207
rtpengine_12.5.1.27-2_amd64.buildinfo
Checksums-Sha256:
7df7d82740e6d43554bc2ef705734f7b2883049ac9df0dbb20763c91a3a97a73 3039
rtpengine_12.5.1.27-2.dsc
5e6e82de23b3b20fed3b912de5b7c78ba41112923f987bb41d9f296d9f9dd9d1 14668
rtpengine_12.5.1.27-2.debian.tar.xz
f7506112a6563b7ae4c57b49d39eee864e1615e76300af59c21b4a664b534d19 18207
rtpengine_12.5.1.27-2_amd64.buildinfo
Files:
304b064a4ca387fcb1bd0f8d16abdf89 3039 net optional rtpengine_12.5.1.27-2.dsc
35ef5b6da41f89a8e690342e386fac13 14668 net optional
rtpengine_12.5.1.27-2.debian.tar.xz
17b1e938967ffc59cd31a86e00bc14c2 18207 net optional
rtpengine_12.5.1.27-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iIYEARYKAC8WIQQq6AO8RS0zF4SC1vh9e2XEKg7IsgUCZ+u5DxEcdnNldmFAZGVi
aWFuLm9yZwAKCRB9e2XEKg7Islg0APjNVlQk1ftVQpOJsFUwRAWYnrlUh4il8uIc
h655PERWAQDaO+wdRcIKdRT38VXeslbxWci2I3/npttUN3uvHFPfDQ==
=k/Pa
-----END PGP SIGNATURE-----
pgpNd6dpuqPfe.pgp
Description: PGP signature
--- End Message ---
