Your message dated Mon, 29 May 2017 13:19:08 +0000
with message-id <e1dfkzg-000cq5...@fasolo.debian.org>
and subject line Bug#861769: fixed in systemd 233-8
has caused the Debian Bug report #861769,
regarding systemd: systemd-timesyncd does not use NTP server set by DHCP when 
NetworkManager is installed
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
861769: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=861769
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: systemd
Version: 232-22
Severity: normal

Dear Maintainers,

When NetworkManager is running /etc/dhcp/dhclient-exit-hooks.d/timesyncd and
other hooks in the directory are not triggered. See #537358 for a very
old report
involving other packages with DHCP hooks.

The widely adopted solution seems to be adding per-package scripts to
/etc/NetworkManager/dispatcher.d and the attached patch does that for systemd.

Cheers,
Balint

PS: The issue has been reported on Launchpad originally:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1685484

-- 
Balint Reczey
Debian & Ubuntu Developer
From 88d3488152bae8bbe4510fdbd9106b4270af5928 Mon Sep 17 00:00:00 2001
From: Balint Reczey <balint.rec...@canonical.com>
Date: Wed, 3 May 2017 17:44:05 +0200
Subject: [PATCH] Set timesyncd's NTP server from DHCP even with NetworkManager

LP: #1685484
---
 debian/extra/dhclient-exit-hooks.d/timesyncd |  2 +-
 debian/extra/dispatcher.d/timesyncd          | 12 ++++++++++++
 debian/systemd.install                       |  1 +
 3 files changed, 14 insertions(+), 1 deletion(-)
 create mode 100755 debian/extra/dispatcher.d/timesyncd

diff --git a/debian/extra/dhclient-exit-hooks.d/timesyncd b/debian/extra/dhclient-exit-hooks.d/timesyncd
index 3cde992..d567dd0 100644
--- a/debian/extra/dhclient-exit-hooks.d/timesyncd
+++ b/debian/extra/dhclient-exit-hooks.d/timesyncd
@@ -12,7 +12,7 @@ timesyncd_servers_setup_add() {
                 return
         fi
 
-        if [ -e $TIMESYNCD_CONF ] && [ "$new_ntp_servers" = "$old_ntp_servers" ]; then
+        if [ -e $TIMESYNCD_CONF ] && grep -q -F "NTP=$new_ntp_servers" $TIMESYNCD_CONF; then
                 return
         fi
 
diff --git a/debian/extra/dispatcher.d/timesyncd b/debian/extra/dispatcher.d/timesyncd
new file mode 100755
index 0000000..cc1f3bc
--- /dev/null
+++ b/debian/extra/dispatcher.d/timesyncd
@@ -0,0 +1,12 @@
+#!/bin/sh
+
+# Call timesyncd DHCP hook on NetworkManager interface events
+
+if [ "$2" = "up" -a -n "${DHCP4_NTP_SERVERS:-}" ]; then
+    env reason="BOUND" \
+        new_ntp_servers="${DHCP4_NTP_SERVERS}" \
+        sh /etc/dhcp/dhclient-exit-hooks.d/timesyncd
+elif [ "$2" = "down" ]; then
+    env reason="STOP" \
+        sh /etc/dhcp/dhclient-exit-hooks.d/timesyncd
+fi
diff --git a/debian/systemd.install b/debian/systemd.install
index b3e0594..905600c 100644
--- a/debian/systemd.install
+++ b/debian/systemd.install
@@ -65,5 +65,6 @@ var/lib
 ../../extra/systemd-sysv-install lib/systemd/
 ../../extra/units/* lib/systemd/system/
 ../../extra/dhclient-exit-hooks.d/ etc/dhcp/
+../../extra/dispatcher.d/ etc/NetworkManager/
 ../../extra/kernel-install.d/* usr/lib/kernel/install.d
 ../../extra/pam.d etc/
-- 
2.7.4


--- End Message ---
--- Begin Message ---
Source: systemd
Source-Version: 233-8

We believe that the bug you reported is fixed in the latest version of
systemd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 861...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Biebl <bi...@debian.org> (supplier of updated systemd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 29 May 2017 14:12:08 +0200
Source: systemd
Binary: systemd systemd-sysv systemd-container systemd-journal-remote 
systemd-coredump systemd-tests libpam-systemd libnss-myhostname 
libnss-mymachines libnss-resolve libnss-systemd libsystemd0 libsystemd-dev udev 
libudev1 libudev-dev udev-udeb libudev1-udeb
Architecture: source
Version: 233-8
Distribution: experimental
Urgency: medium
Maintainer: Debian systemd Maintainers 
<pkg-systemd-maintainers@lists.alioth.debian.org>
Changed-By: Michael Biebl <bi...@debian.org>
Description:
 libnss-myhostname - nss module providing fallback resolution for the current 
hostname
 libnss-mymachines - nss module to resolve hostnames for local container 
instances
 libnss-resolve - nss module to resolve names via systemd-resolved
 libnss-systemd - nss module providing dynamic user and group name resolution
 libpam-systemd - system and service manager - PAM module
 libsystemd-dev - systemd utility library - development files
 libsystemd0 - systemd utility library
 libudev-dev - libudev development files
 libudev1   - libudev shared library
 libudev1-udeb - libudev shared library (udeb)
 systemd    - system and service manager
 systemd-container - systemd container/nspawn tools
 systemd-coredump - tools for storing and retrieving coredumps
 systemd-journal-remote - tools for sending and receiving remote journal logs
 systemd-sysv - system and service manager - SysV links
 systemd-tests - tests for systemd
 udev       - /dev/ and hotplug management daemon
 udev-udeb  - /dev/ and hotplug management daemon (udeb)
Closes: 861769 863277
Changes:
 systemd (233-8) experimental; urgency=medium
 .
   * Bump debhelper compatibility level to 10
   * Drop versioned Build-Depends on dpkg-dev.
     It's no longer necessary as even Jessie ships a new enough version.
   * timesyncd: don't use compiled-in list if FallbackNTP has been configured
     explicitly (Closes: #861769)
   * resolved: fix null pointer p->question dereferencing.
     This fixes a bug which allowed a remote DoS (daemon crash) via a crafted
     DNS response with an empty question section.
     Fixes: CVE-2017-9217 (Closes: #863277)
Checksums-Sha1:
 ebf12c8f5ca0eb96d511d89b15a2e8edd8871b72 4833 systemd_233-8.dsc
 41b4dbdd6f8415a417493d3057d33dc55cb0ad5f 142576 systemd_233-8.debian.tar.xz
 799b9e47b482a4310b0ff590c243e7ae3289f675 10026 systemd_233-8_source.buildinfo
Checksums-Sha256:
 d5512586472d21601e4ce164a4a3cd27de4ee099773f1e705287a73b5d325958 4833 
systemd_233-8.dsc
 6316a7e78613bcd4cc816d70c01cb82604c83034a09a378422294fd3fdd42580 142576 
systemd_233-8.debian.tar.xz
 0982820894677aca6515b27eb390c56be605dd0a306444ab0793eb26ce0d94e7 10026 
systemd_233-8_source.buildinfo
Files:
 a39c51f94ec5f6eb951c60098dd60e24 4833 admin optional systemd_233-8.dsc
 652310a2cf055166b9b0bc8775040def 142576 admin optional 
systemd_233-8.debian.tar.xz
 2a55827aa628365f5503b1a10036a499 10026 admin optional 
systemd_233-8_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEECbOsLssWnJBDRcxUauHfDWCPItwFAlksGw0ACgkQauHfDWCP
Ity8YQ//VL3M2dCz4FK3gG5WtsgctkUM53tftMCdE5sBB2KkWvoteqLEc0N8F9i+
N9ifobEU8d9mKwTxmsF0j9ZI8YObokL7k0M93AHt8t3eg08yh7Cw5PlIt7JM+p0a
6mEfc2xtDR8vo9CG6123EmxtHixSJ87vAlu4yVt1UVinJkJyMhORap32kVDIK3QI
DnH8uD/+t4Av06T/V76f1+tXRUTQ1WtE9Msjpdp0CP8dYpmeLXTGdgL4DtM/IM/8
I7+++IWPbY9A9/HNePoEDDoyvUiUBc8WJSJw2SSzfRO9o0khGTEiBeEU2BcBTA3o
L2PgLQeOQrQag6JI2Y70KWZtZ4mZqZSiBnBqPZRfDDQSFdSNCn8stz97ftbs0wQH
W4vssUJIwekRzXnMwWGlUxtYVPVi4Y7nFo722ix9C3MqyG+GUANOIGvqKmOK45xS
07gnQ8XLxpRZQneW3gFIfm24L2zHUVyFAXFG7FR6hv46fMy1t0H6qtwZ8ww5Dh48
RSyIdsoX5JOkx/Y+q7XXxxHP+t3+l9S00gZjbJiYqZ3zWgXXfU0xatAw+4BKFpvl
atzdSjraaoGUtcdVsYZcYe21MBmuOw0Lr/FrGmReblUPthvtUevq2lOSyOo82hDX
jE6CpySAW8K9Go1clUQ3GS3p4nZaYZNLitEeayCSft3JGho0fEc=
=RsXR
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
Pkg-systemd-maintainers mailing list
Pkg-systemd-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-systemd-maintainers

Reply via email to