Dear Felipe, Thanks for your feedback!
> Note that this is not the only place that this description appears. It
> also shows in the output of "systemctl status adjtimex.service", or
> "systemctl list-units". This should really be a full descriptive
> sentence. Maybe, "Adjust kernel time variables".
I think you might misunderstand me.
The description you proposed would generate the following log:
[DATE TIME] [HOSTNAME] systemd[1]: Starting set the kernel time variables...
[DATE TIME] [HOSTNAME] systemd[1]: Started set the kernel time variables.
or
[DATE TIME] [HOSTNAME] systemd[1]: Starting Adjust kernel time variables...
[DATE TIME] [HOSTNAME] systemd[1]: Started Adjust kernel time variables.
What I proposed was:
[DATE TIME] [HOSTNAME] systemd[1]: Starting the kernel time
variables setting...
[DATE TIME] [HOSTNAME] systemd[1]: Started the kernel time
variables setting.
IMHO, it looks more natural.
Yes, I found other existing systemd service also use the way you
propose, like "systemd-tmpfiles-setup.service":
Nov 30 23:43:32 sid systemd[1]: Starting Create Volatile Files and
Directories...
Nov 30 23:43:32 sid systemd[1]: Started Create Volatile Files and
Directories.
I consider it's minor bug to say "starting verb" or "started verb",
which is better to fix in the future.
>> Environment="TICK=10000 FREQ=0"
> I don't think this works. There should be no quotes there, or systemd
> might treat TICK variable as containing "10000 FREQ=0".
Thanks for pointing this out.
Yes, it's totally not working.
I confirmed by commenting out "EnvironmentFile" line, and found
"ExecStart" command failed because of no FREQ is set.
changing from
Environment="TICK=10000 FREQ=0"
to
Environment="TICK=10005" "FREQ=0"
will fix it.
>> EnvironmentFile=-/etc/default/adjtimex
>> ExecStart=/sbin/adjtimex -tick "$TICK" -frequency "$FREQ"
>
> I think the quotes are superfluous. If you want to preserve quoting,
> systemd does it by using ${TICK} and ${FREQ} syntax.
It seems fine as it was. However, following spec is always a good
thing, so I changed to what you proposed:
ExecStart=/sbin/adjtimex -tick ${TICK} -frequency ${FREQ}
Thanks again for your review!
Cheers,
Roger
adjtimex.service
Description: Binary data
_______________________________________________ Pkg-systemd-maintainers mailing list Pkg-systemd-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-systemd-maintainers
