Your message dated Sun, 07 Dec 2014 16:19:22 +0100
with message-id
<1417965562.3745619.199855845.144a6...@webmail.messagingengine.com>
and subject line Re: Bug#772266: dh-systemd: bashism in /bin/sh script
has caused the Debian Bug report #772266,
regarding dh-systemd: bashism in /bin/sh script
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
772266: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=772266
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: dh-systemd
Severity: minor
Version: 1.22
User: debian-rele...@lists.debian.org
Usertags: goal-dash
Hi,
I've ran checkbashisms (from the 'devscripts' package) over the whole
archive and I found that your package has a /bin/sh script that uses a
"bashism".
checkbashisms' output:
> possible bashism in ./usr/share/dh-systemd/skeleton.redhat line 39 ($"foo"
> should be eval_gettext "foo"):
> echo -n $"Starting $NAME: "
> possible bashism in ./usr/share/dh-systemd/skeleton.redhat line 50 ($"foo"
> should be eval_gettext "foo"):
> echo -n $"Stopping $NAME: "
> possible bashism in ./usr/share/dh-systemd/skeleton.redhat line 116
($"foo"
> should be eval_gettext "foo"):
> echo $"Usage: $0
> {start|stop|status|restart|condrestart|try-restart|reload|force-reload}"
Not using bash (or a Debian Policy compliant shell interpreter that doesn't
provide such an extra feature) as /bin/sh is likely to lead to errors or
unexpected behaviours. Please be aware that dash is the default /bin/sh.
Please closely examine the above output and the script, and determine
what the proper severity of the bug is, and adjust it accordingly. If
it's important or greater please hurry to get this fixed for jessie.
Hints about how to fix bashisms can be found at:
https://wiki.ubuntu.com/DashAsBinSh
Thanks in advance,
Raphael Geissert
--- End Message ---
--- Begin Message ---
skeleton.redhat was written by RH folks and meant to be used on
RH/Fedora, so it's definitely false-positive.
Cheers,
Ondrej
On Sat, Dec 6, 2014, at 21:19, Michael Biebl wrote:
> Am 06.12.2014 um 12:26 schrieb Raphael Geissert:
> > Package: dh-systemd
> > Severity: minor
> > Version: 1.22
> > User: debian-rele...@lists.debian.org
> > Usertags: goal-dash
> >
> > Hi,
> >
> > I've ran checkbashisms (from the 'devscripts' package) over the whole
> > archive and I found that your package has a /bin/sh script that uses a
> > "bashism".
> >
> > checkbashisms' output:
> >> possible bashism in ./usr/share/dh-systemd/skeleton.redhat line 39 ($"foo"
> >> should be eval_gettext "foo"):
> >> echo -n $"Starting $NAME: "
> >> possible bashism in ./usr/share/dh-systemd/skeleton.redhat line 50 ($"foo"
> >> should be eval_gettext "foo"):
> >> echo -n $"Stopping $NAME: "
> >> possible bashism in ./usr/share/dh-systemd/skeleton.redhat line 116
> > ($"foo"
> >> should be eval_gettext "foo"):
> >> echo $"Usage: $0
> >> {start|stop|status|restart|condrestart|try-restart|reload|force-reload}"
> >
> >
> >
>
> Afaik this is a false positive. That file is a skeleton which is
> processed by systemd2init and you'd have to actually check the resulting
> shell scripts.
>
> CCing Ondřej, since this is his code.
>
>
> Michael
>
>
> --
> Why is it that all of the instruments seeking intelligent life in the
> universe are pointed away from Earth?
>
> Email had 1 attachment:
> + signature.asc
> 1k (application/pgp-signature)
--
Ondřej Surý <ond...@sury.org>
Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server
--- End Message ---
_______________________________________________
Pkg-systemd-maintainers mailing list
Pkg-systemd-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-systemd-maintainers
