Your message dated Thu, 29 Aug 2019 15:55:05 +0000
with message-id <[email protected]>
and subject line Bug#936032: fixed in systemd 242-5
has caused the Debian Bug report #936032,
regarding systemd: Main process of service unit gets killed on reload if 
ExecReload fails
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
936032: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=936032
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: systemd
Version: 241-5
Severity: important
Tags: upstream

Dear Maintainer,

systemd kills the main process of a service unit after issuing a reload
command, if the command in `ExecReload` fails. This is a regression
introduced in v239 by upstream commit ec5b145 [1].

This behavior is not an expected one and changed systemd's behavior
during the reload of a unit. Before v239, an `ExecReload` command with
a non-successful exit code, would not kill the main process of the
unit. The change may cause problems in production environments, when
configuration changes happen, that include typos or syntax errors.

Imagine the following scenario:
  * Production server runs haproxy
  * A configuration change happens
  * A reload gets triggered from a configuration management tool
  * HAProxy's `ExecReload` command, `haproxy -c` exits with code 1 due
    to a syntax error.
  * systemd kills HAProxy, causing an outage

This issue has been reported upstream in issue #11238 [2] and has been
fixed in commit d611cfa [3] of pull request #13098 [4]. The fix is
quite fresh (2019-07-17) and seems that will be included in v243.

Unfortunately, this issue has unexpected side-effects and may cause
problems to Debian users that use systemd to manage production-grade
services, after upgrading to Buster.

I tried to apply the fix [3] on the package's source tree for Buster
and it seems to work; the patch applies cleanly, the package gets
builded and systemd behaves as expected.

I think that it is possible to include this fix in Buster.

Thanks for maintaining systemd in Debian,
Nikos

[1] 
https://github.com/systemd/systemd/commit/ec5b1452ac73e41274f9b3ca401f813fa079b9f0
[2] https://github.com/systemd/systemd/issues/11238
[3] 
https://github.com/systemd/systemd/commit/86bc88ca8dbdeeefc2e5032636b9677fda126184
[4] https://github.com/systemd/systemd/pull/13098

-- Package-specific info:

-- System Information:
Debian Release: 10.0
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-5-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages systemd depends on:
ii  adduser          3.118
ii  libacl1          2.2.53-4
ii  libapparmor1     2.13.2-10
ii  libaudit1        1:2.8.4-3
ii  libblkid1        2.33.1-0.1
ii  libc6            2.28-10
ii  libcap2          1:2.25-2
ii  libcryptsetup12  2:2.1.0-5
ii  libgcrypt20      1.8.4-5
ii  libgnutls30      3.6.7-4
ii  libgpg-error0    1.35-1
ii  libidn11         1.33-2.2
ii  libip4tc0        1.8.2-4
ii  libkmod2         26-1
ii  liblz4-1         1.8.3-1
ii  liblzma5         5.2.4-1
ii  libmount1        2.33.1-0.1
ii  libpam0g         1.3.1-5
ii  libseccomp2      2.3.3-4
ii  libselinux1      2.8-1+b1
ii  libsystemd0      241-5
ii  mount            2.33.1-0.1
ii  util-linux       2.33.1-0.1

Versions of packages systemd recommends:
ii  dbus            1.12.16-1
ii  libpam-systemd  241-5

Versions of packages systemd suggests:
ii  policykit-1        0.105-25
pn  systemd-container  <none>

Versions of packages systemd is related to:
pn  dracut           <none>
ii  initramfs-tools  0.133
ii  udev             241-5

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: systemd
Source-Version: 242-5

We believe that the bug you reported is fixed in the latest version of
systemd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Biebl <[email protected]> (supplier of updated systemd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 29 Aug 2019 16:18:18 +0200
Source: systemd
Architecture: source
Version: 242-5
Distribution: unstable
Urgency: medium
Maintainer: Debian systemd Maintainers 
<[email protected]>
Changed-By: Michael Biebl <[email protected]>
Closes: 913222 935091 936032
Changes:
 systemd (242-5) unstable; urgency=medium
 .
   [ Dan Streetman ]
   * d/rules: add CONFFGLAGS_UPSTREAM to dh_auto_configure -- params
 .
   [ Michael Biebl ]
   * core: never propagate reload failure to service result.
     Fixes a regression introduced in v239 where the main process of a
     service unit gets killed on reload if ExecReload fails. (Closes: #936032)
   * shared/seccomp: add sync_file_range2.
     Some architectures need the arguments to be reordered because of alignment
     issues. Otherwise, it's the same as sync_file_range.
     Fixes sync_file_range failures in nspawn containers on arm, ppc.
     (Closes: #935091)
   * bash-completion: don't sort syslog priorities.
     By default, the available completions are sorted alphabetically, which
     is counterproductive in case of syslog priorities. Override the default
     behavior using the `nosort` option. (Closes: #913222)
   * test-bpf: skip test when run inside containers
Checksums-Sha1:
 1f9b59bb6ffe8b61fb298789740ab577b5acbd0a 4947 systemd_242-5.dsc
 33705a2b645651029e23584eee2bf6b70180fc5c 155568 systemd_242-5.debian.tar.xz
 b48ece9e1b0a3ab4d4f8308a68d9d42ecccef7a4 9408 systemd_242-5_source.buildinfo
Checksums-Sha256:
 51202ab44831fc4eb5c5d8cbabfead78f248ff201dfdeeb95cfe3030b3a9f2c1 4947 
systemd_242-5.dsc
 c85c3bcf9939d0ba0f7a06abfee4e8c870664b01fbb440b1978a4357a2a9e466 155568 
systemd_242-5.debian.tar.xz
 efe4668ae5cad4f25801bc15d1ea6667c3b01fd5ca09f2b032d5a81fb71adc90 9408 
systemd_242-5_source.buildinfo
Files:
 59dd97440a2b64511b37cdfe7a1f0a4b 4947 admin optional systemd_242-5.dsc
 9a3ee17e006fd89f0d9c9d8caa1cf5e5 155568 admin optional 
systemd_242-5.debian.tar.xz
 02374233288d33ad6535993c67ff0320 9408 admin optional 
systemd_242-5_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEECbOsLssWnJBDRcxUauHfDWCPItwFAl1n6r8ACgkQauHfDWCP
ItzO3w//YR6qdW3ZoUzD+pnVPqfzocxA6T8lMDxuE8UXQE53ZIfd/MjnXFD6OHFG
+m2WhODKUrfzwRmLCridyOr7+Y5xr2rQkML1AeHiGfqThmcYuvHy37Pu7xF5Y4Rl
/7nmajXAP+7h55p3Bce+YhfeWr7YiZoL00zuOe3YZ+kmcxdCUcDmeQLH9hkCmLf1
jc6WcQNdJdiZdeMIDLzO7BcqqtwaIeX+X1LC4HI/eT/kOrASAzUw1BfxFtnzQ/Pu
6ppkkm/y6QYF9Wmpb0deA8dDa+5YA9JJTUHupxk5qPYH+bWZp6Y5q1JaIvEPuRlu
pe8gBPtCs8NravvoA4c5AXNOyJViqG8GHnmNkbp0FkVtlrr2em7kxrdSDe8thwKR
FfHwS00qmHiYd8SU520Bwx6MrO+gPYqWkFsOLPB8KqdQwBTd2cKksf1ih6TReVmF
lSuykLfPgGN2Aqz84oSYmVViOFW2JDjxkpbnFpfe24MbroWKdrI8kuZTx8x41KIf
jw/kbXmeBCw/e3i/XSgu3B053K1zx+HiRxeYEF1056sXcWsSowiCCdkx7dVfe08L
3i3Ay2tf2eGkHTdmJxuoW2zgh9wcJ7MQG7a9QCCAn9nqNuk6X1/6SLLUQAoy0em9
npC5jktHfup8kbt+hTsw1QOQWOzOTttwsymHW/j5FL47e9mbhro=
=MvSV
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
Pkg-systemd-maintainers mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-systemd-maintainers

Reply via email to