Please find, for review, the debconf templates and packages descriptions for the chef source package.
This review will last from Friday, January 31, 2014 to Monday, February 10, 2014. Please send reviews as unified diffs (diff -u) against the original files. Comments about your proposed changes will be appreciated. Your review should be sent as an answer to this mail. When appropriate, I will send intermediate requests for review, with "[RFRn]" (n>=2) as a subject tag. When we will reach a consensus, I send a "Last Chance For Comments" mail with "[LCFC]" as a subject tag. Finally, a summary will be sent to the review bug report, and a mail will be sent to this list with "[BTS]" as a subject tag. Rationale: --- chef.old/debian/chef.templates 2014-01-23 08:57:23.092735010 +0100 +++ chef/debian/chef.templates 2014-01-31 08:08:45.718088969 +0100 @@ -1,7 +1,8 @@ Template: chef/chef_server_url Type: string -_Description: URL of Chef Server (e.g., http://chef.example.com:4000): - This is the full URI that clients will use to connect to the - server. - . - This will be used in /etc/chef/client.rb as 'chef_server_url'. +_Description: URL of Chef server + Please choose the full URI that clients will use to connect to the + server (for instance: http://chef.example.com:4000). + . + This setting will be stored in /etc/chef/client.rb as + "chef_server_url". First of all, the entire template was hard-formatted (double space at the beginning og each line, and indeed broken (double space before dot in the paragraph separatior). So, let's fix this. Then I reworded to use of standard formulation in such cases (including "make a sentence") and move the example in the long part. Also use double quotes. --- chef.old/debian/control 2014-01-23 08:57:23.092735010 +0100 +++ chef/debian/control 2014-01-31 08:09:36.727439490 +0100 @@ -38,7 +38,7 @@ Conflicts: libchef-ruby (<< 0.10.10-1~), libchef-ruby1.8 (<< 0.10.10-1~) Replaces: libchef-ruby (<< 0.10.10-1~), libchef-ruby1.8 (<< 0.10.10-1~) Breaks: chef-solr (<< 11) -Description: clients for the chef systems integration framework +Description: Chef systems integration framework - clients Debatable as there is only one binary package but I guess that "Chef" coming first is better. And capitalize it as this seem to be the way this is done upstream. Chef is a systems integration framework and configuration management library written in Ruby. Chef provides a Ruby library and API that can be used to bring the benefits of configuration management to an entire infrastructure. @@ -46,5 +46,5 @@ Chef can be run as a client (chef-client) to a server, or run as a standalone tool (chef-solo). Configuration recipes are written in a pure Ruby DSL. . - This package contains the chef-client, chef-solo and knife binaries as well + This package provides the chef-client, chef-solo and knife binaries as well as the chef library. s/contains/provides: dle style..:-) --
Template: chef/chef_server_url Type: string _Description: URL of Chef server Please choose the full URI that clients will use to connect to the server (for instance: http://chef.example.com:4000). . This setting will be stored in /etc/chef/client.rb as "chef_server_url".
--- chef.old/debian/chef.templates 2014-01-23 08:57:23.092735010 +0100 +++ chef/debian/chef.templates 2014-01-31 08:08:45.718088969 +0100 @@ -1,7 +1,8 @@ Template: chef/chef_server_url Type: string -_Description: URL of Chef Server (e.g., http://chef.example.com:4000): - This is the full URI that clients will use to connect to the - server. - . - This will be used in /etc/chef/client.rb as 'chef_server_url'. +_Description: URL of Chef server + Please choose the full URI that clients will use to connect to the + server (for instance: http://chef.example.com:4000). + . + This setting will be stored in /etc/chef/client.rb as + "chef_server_url". --- chef.old/debian/control 2014-01-23 08:57:23.092735010 +0100 +++ chef/debian/control 2014-01-31 08:09:36.727439490 +0100 @@ -38,7 +38,7 @@ Conflicts: libchef-ruby (<< 0.10.10-1~), libchef-ruby1.8 (<< 0.10.10-1~) Replaces: libchef-ruby (<< 0.10.10-1~), libchef-ruby1.8 (<< 0.10.10-1~) Breaks: chef-solr (<< 11) -Description: clients for the chef systems integration framework +Description: Chef systems integration framework - clients Chef is a systems integration framework and configuration management library written in Ruby. Chef provides a Ruby library and API that can be used to bring the benefits of configuration management to an entire infrastructure. @@ -46,5 +46,5 @@ Chef can be run as a client (chef-client) to a server, or run as a standalone tool (chef-solo). Configuration recipes are written in a pure Ruby DSL. . - This package contains the chef-client, chef-solo and knife binaries as well + This package provides the chef-client, chef-solo and knife binaries as well as the chef library.
Source: chef Section: ruby Priority: optional Maintainer: Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org> Uploaders: Tollef Fog Heen <tfh...@debian.org> Build-Depends: debhelper (>= 8.2), gem2deb (>= 0.2.13~), po-debconf Standards-Version: 3.9.5 Vcs-Git: git://anonscm.debian.org/pkg-ruby-extras/chef.git Vcs-Browser: http://anonscm.debian.org/gitweb?p=pkg-ruby-extras/chef.git;a=summary Homepage: http://wiki.opscode.com/display/chef XS-Ruby-Versions: all Package: chef Architecture: all XB-Ruby-Versions: ${ruby:Versions} Depends: chef-zero (>= 1.6.2), erubis (>= 2.7), ohai (>= 6), ruby | ruby-interpreter, ruby-diff-lcs (>= 1.2.4), ruby-highline (>= 1.6.9), ruby-json (>= 1.4.4), ruby-mixlib-authentication (>= 1.3), ruby-mixlib-cli (>= 1.3), ruby-mixlib-config (>= 2), ruby-mixlib-log (>= 1.3), ruby-mixlib-shellout (>= 1.2), ruby-net-ssh (>= 1:2.6), ruby-net-ssh-multi (>= 1.1), ruby-rest-client (<< 1.7.0), ruby-rest-client (>= 1.0.4), ruby-yajl (>= 1.1), ucf, ${misc:Depends}, ${shlibs:Depends} Provides: libchef-ruby, libchef-ruby1.8 Conflicts: libchef-ruby (<< 0.10.10-1~), libchef-ruby1.8 (<< 0.10.10-1~) Replaces: libchef-ruby (<< 0.10.10-1~), libchef-ruby1.8 (<< 0.10.10-1~) Breaks: chef-solr (<< 11) Description: Chef systems integration framework - clients Chef is a systems integration framework and configuration management library written in Ruby. Chef provides a Ruby library and API that can be used to bring the benefits of configuration management to an entire infrastructure. . Chef can be run as a client (chef-client) to a server, or run as a standalone tool (chef-solo). Configuration recipes are written in a pure Ruby DSL. . This package provides the chef-client, chef-solo and knife binaries as well as the chef library.
signature.asc
Description: Digital signature
_______________________________________________ Pkg-ruby-extras-maintainers mailing list Pkg-ruby-extras-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers
