Hi, On 25/06/17 18:29, Jaromír Mikeš wrote: > 2016-12-31 3:22 GMT+01:00 Jaromír Mikeš <mira.mi...@gmail.com > <mailto:mira.mi...@gmail.com>>: > > Hi, > > here is one last minute package ;) > Can someone review and upload this package to NEW please? > Would be great if this would slip in before freeze ;) > > Can someone upload avldrums.lv2 package now for me please?
debian/rules: > ifeq ($(DEB_HOST_ARCH_CPU),amd64) > export OPTIMIZATIONS += -msse -msse2 -mfpmath=sse > endif You should be able to remove this bit. Those 3 options are already enabled by default on amd64. > override_dh_auto_clean: > Why? > override_dh_auto_configure: > dh_auto_configure -- \ > --prefix=/usr dh_auto_configure is a no-op for "Makefile only" packages. > > override_dh_auto_build: > $(MAKE) \ > PREFIX=/usr You should use "dh_auto_build -- PREFIX=/usr" so parallel builds work > override_dh_auto_install: > $(MAKE) install \ > DESTDIR=$(CURDIR)/debian/tmp \ > PREFIX=/usr And "dh_auto_install" here. debian/watch file seems to be broken? the "fluidsynth" and "robtk" directories look like external modules and should be de-bundled. I see the -data package just contains some soundfonts. Would it be sensible to put these in the "public" soundfont directory (/usr/share/sounds/sf2) or are they only usable with avldrums? Building in git: > Version: debian/0.2.2-1-9 -> debian/0-9 debian/2-9 debian/2-9 debian/1-9 > expr: non-integer argument > git2lv2.mk:37: *** "Cannot extract required LV2 minor-version parameter". > Stop. While this only happens when using git, it is very frustrating. I think you should override the "avldrums_VERSION" variable to fix it. I haven't done an indepth copyright check, but I can't seen any obvious problems. Thanks, James
signature.asc
Description: OpenPGP digital signature
_______________________________________________ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
