On 2015-11-15 09:39, Mattia Rizzolo wrote: > Indeed the commit message lack that information, but it's needed to make > the build reproducible, as the final d/changelog says: > > * Made build reproducible > * Patch to allow setting of DATE in about-dialog > * Set BUILD_DATE to date from debian/changelog >
yep exactly. sorry for not being that clear in the commit logs. as it is, the reproducible thing was implemented in two commits: the one mira was referring to (94c8da771) and the previous one (a18cc99a). while a18cc99a also does not mention "reproducible build" in the commit message, at least the actual patch contains that information: a18cc99a is really a quilt patch and the DEP-3 header says "allow setting of the displayed build-date so we can make builds reproducible". which i think explains why that piece of information was missing: it's slightly tedious to repeat the same thing again and again (esp. when committing DEP3 documented quilt patches via git). probably a "tag" style commit-message would have helped: "[reproducible] use date from debian/changelog as compile-date" gmasdr IOhannes _______________________________________________ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
