Your message dated Wed, 24 Jun 2015 13:34:09 +0000
with message-id <e1z7kob-0006t9...@franck.debian.org>
and subject line Bug#789248: fixed in bs1770gain 0.4.4-1
has caused the Debian Bug report #789248,
regarding bs1770gain: Fail to build on archs with unsigned char
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
789248: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=789248
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: bs1770gain
Version: 0.4.3-1
Severity: wishlist
Tags: patch
The first build of bs1770gain on the autobuilders showed a common error
on several architectures:
ffsox_csv2avdict.c:261:10: error: comparison is always false due to limited
range of data type [-Werror=type-limits]
if (EOF==(*wp=getc(b->f)))
^
cc1: all warnings being treated as errors
This is caused by 'char *wp' being unable to store the value of EOF
(often defined to -1) when char is unsigned. The underlying cause is
that the return type of getc() is 'int', not 'char', and should not be
stored directly in a char before comparing it to EOF.
I believe this untested patch solve the issue:
diff --git a/libffsox-2/ffsox_csv2avdict.c b/libffsox-2/ffsox_csv2avdict.c
index e0a9474..ce3f781 100755
--- a/libffsox-2/ffsox_csv2avdict.c
+++ b/libffsox-2/ffsox_csv2avdict.c
@@ -255,11 +255,14 @@ static int priv_get_utf8(priv_t *b)
static unsigned short mask[] = {192, 224, 240};
char *wp=b->ch;
+ int firstbyte;
size_t n;
// read first byte into buffer
- if (EOF==(*wp=getc(b->f)))
+ firstbyte = getc(b->f);
+ if (EOF==firstbyte)
goto error;
+ *wp = (char)firstbyte;
// check how many more bytes need to be read for character
n = 0;
--
Happy hacking
Petter Reinholdtsen
--- End Message ---
--- Begin Message ---
Source: bs1770gain
Source-Version: 0.4.4-1
We believe that the bug you reported is fixed in the latest version of
bs1770gain, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 789...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Petter Reinholdtsen <p...@debian.org> (supplier of updated bs1770gain package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 24 Jun 2015 11:36:52 +0000
Source: bs1770gain
Binary: bs1770gain bs1770gain-dbg
Architecture: source
Version: 0.4.4-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Team
<pkg-multimedia-maintainers@lists.alioth.debian.org>
Changed-By: Petter Reinholdtsen <p...@debian.org>
Description:
bs1770gain - measure and adjust audio and video sound loudness
bs1770gain-dbg - measure and adjust audio and video sound loudness (debug
symbols)
Closes: 789248 789250 789254
Changes:
bs1770gain (0.4.4-1) unstable; urgency=medium
.
* New upstream release 0.4.4.
- Fixes problem with stuttering sound after transcoding
(Closes: #789254).
- Fixes build problem when char is unsigned (Closes: #789248).
- Dropped 10-unsigned-char-archs.diff and refreshed
20-audio-decode-problem.diff now included upstream.
- Added 30-strict-cast-align.diff to ensure the build fail on
architectures where -Wstrict-align give warning and fix the
known cases after verifying they are safe (Closes: #789250).
Checksums-Sha1:
f9dcc7daa092223dc33c7847b88150320242011f 2219 bs1770gain_0.4.4-1.dsc
5e46938719b82619593267161685e510f7fec6c6 161925 bs1770gain_0.4.4.orig.tar.gz
a7ccd998ccfd3608a4512965a46cf910c420119f 523032
bs1770gain_0.4.4-1.debian.tar.xz
Checksums-Sha256:
1d0f961ecba43eb4dd8abec1a63808e0bebe1a77e212e38078d4c8e1a0494c64 2219
bs1770gain_0.4.4-1.dsc
c5a94280740b5d0b9c0311fc36aa6ab13c2752f36fd26a1aa51ed3ec0e951595 161925
bs1770gain_0.4.4.orig.tar.gz
67041600e60f965895c8e6a5a4d6d20cc52ccb43b53885883b7393f47757db88 523032
bs1770gain_0.4.4-1.debian.tar.xz
Files:
e59df4f6bbaf69d886d922c5a80c5cb9 2219 sound optional bs1770gain_0.4.4-1.dsc
6a15909609e315a3c3a0d90abd858646 161925 sound optional
bs1770gain_0.4.4.orig.tar.gz
a955b4d739de856bd82d90b913e40d8f 523032 sound optional
bs1770gain_0.4.4-1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
Comment: Debian powered!
iQJ8BAEBCgBmBQJVip5DXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRGM0REMDlGOERBODdEMURGNTA0NkM5OUIw
NjEyRjQ5NDRFQ0RDRDVBAAoJEAYS9JROzc1aQUcQALz4+mc0IK5C0jfoWP/fNNsD
Tybb34u9pgGmGUnK6Lw1hZ6JE4B3vPCRnOGtMvEZeHntdSMyyp0CYHr1caL/ovwA
jz6zG67QfcyMBID9k5HxNZ/eSSX0EZhjdBzzdL5jCBLoka1YMeyeSWmLaWp1OLoG
bl9ILq75qMokEEZtCVACcag9OW3HhWA2rAUpLqkOSfuwKy7Y9BxYAirAdC3dHfMR
ysSds8Kn2UEftVmaVYUcxF9ZZqQu30uZEBWeEjmo53K+DtnwUQgvRqPv+LzWYlss
KYNdEIR6Z/rmXDcLJZGhCVdgMeGTWfil6p8APCjtP7OHEd6SBP1YLqL75YeW+GrT
f/067la7KGblnqrCc908NzLH9QTlsBLtLZ86PoTv4wKoTOs/DxVs3FxVGbE4HslU
9BYyd4l0xovQAiAKWz1i86Hx/LCIg6rjlzprL/Hlfv0oXtoTOvxpgh/LEGJGExPO
adx8e3BjWrfAIRj5lksL1VfvcIOC9ITelMJSmndzq+qbQccL0/ZEm34HE9hdme0S
vf7SaWfII/PXl8wUYpfQNFfe6vFTSVnpKWt6rHUNNqxaJJkEWeBoCCy4kpvbNvA0
dAMWFHjC37Y3+wNoOmJEaBAXHOx+rK5qxnlROTR7h6IT9VBKVgQQvDZuIWMrzqxG
7lyF/l0j7Fpr74+UCrvY
=imOS
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
