On 02/17/2015 07:50 PM, Felipe Sateler wrote: >> As for DDs: ales...@debian.org or umlae...@debian.org, we have even more >> in the multimedia team. > > I am happy to upload, but I cannot commit to reviewing the packaging > on my own. If other members of the team help up reviewing the package, > I am willing to sponsor. >
me too (and I am personally interested in ptp packages). however, i would welcome it if the package would be team-maintained under the pkg-multimedia umbrella. anyhow, i'm currently doing a quick review of the package. some notes: - i very much prefer to build the package using git(-buildpackage) to just buliding packages from mentors.d.n, as this is my proven toolchain to build in a chroot environment. i am not a gitpkg user though, so i need some help, which you already provide in the debian/README.source (thanks for that!). unfortunately the information therein is not sufficient (and the pristine-tar line mentioning "syncevolution" is rather suspicious). i cloned http://tikei.de/git/linuxptp-debian.git and setup the quilt-patches hook; but running `gitpkg master` gives me the following error: ~~~ $ gitpkg master git archive exporting master preparing ../deb-packages/linuxptp/linuxptp-1.5 dpkg-source -b linuxptp-1.5 dpkg-source: info: using source format `3.0 (quilt)' dpkg-source: info: building linuxptp using existing ./linuxptp_1.5.orig.tar.gz patching file makefile Reversed (or previously applied) patch detected! Skipping patch. 1 out of 1 hunk ignored dpkg-source: info: the patch has fuzz which is not allowed, or is malformed dpkg-source: info: if patch '0001-Adjust-installation-directory-for-Debian.patch' is correctly applied by quilt, use 'quilt refresh' to update it dpkg-source: error: LC_ALL=C patch -t -F 0 -N -p1 -u -V never -g0 -E -b -B .pc/0001-Adjust-installation-directory-for-Debian.patch/ --reject-file=- < linuxptp-1.5.orig.zcTD_d/debian/patches/0001-Adjust-installation-directory-for-Debian.patch gave error exit status 1 ~~~ - as this package has never been in debian before, you can trim the debian/changelog to a bare minimum (that is: a single section for "1.5-1" [sic!]) - there's a typo in README.Debian: "I also uses eth0" should probably read "It also uses eth0". it also might make a bit more sense to use "eth1" in the example (as the example you give does changes the behaviour to the original one :-)) - debian/rules there seems to be some cruft at the beginning of the file. e.g. why don't you just use `dpkg-parsechangelog -S Source` to get the srcpackage name? also you go through some hoops to parse the upstream-version from the debian/changelog, but then you hardcode UPSTREAMTAG to "upstream/1.5". most likely you can delete lines 3..8 - configuration files: any reasons you don't put all configuration files into /etc/ptp4l/ ? this might allow you to replace the override_dh_auto_install cruft by a simple debian/install file (but this might rename the /etc/ptp4l.conf to /etc/ptp4l/default.conf) i still have to do some functionality tests of the package... fgmsard IOhannes
signature.asc
Description: OpenPGP digital signature
_______________________________________________ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
