Quoting YunQiang Su (2014-10-27 15:16:44) > On Mon, Oct 27, 2014 at 9:58 PM, Jonas Smedegaard <d...@jones.dk> wrote: >> If I understand your patch correctly (have only read it briefly) the >> first lines are better written without making shell calls, like >> this: >> >> WAF_EXTRA_ARGS = $(filter-out -j%,$(DEB_MAKE_EXTRA_ARGS)) >> WAF_JOBS = $(filter -j%,$(DEB_MAKE_EXTRA_ARGS)) >> > > Yes, using functions from make should be better. > >> ...and even better by using underlying variable instead of extracting >> from DEB_MAKE_EXTRA_ARGS. > > I am not very familiar with cdbs, so no idea about it.
Fully understood, and not a problem: I just mention for the record, in case someone would want to dive in and refine even further :-) I do expect your original patch to work fine - all of this is just suggestions for improvements. Thanks, again, for your reporting this issue and providing a patch! Regards, - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: signature
_______________________________________________ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
