On Sat, Aug 31, 2013 at 2:26 PM, Thomas Orgis <thomas-fo...@orgis.org> wrote:
> (I'm also CCing the FreeBSD port maintainer, as I imagine they want that
> handled, too.)
>
> Am Sat, 31 Aug 2013 10:03:46 +0200
> schrieb Reinhard Tartler <siret...@gmail.com>:
>
>> Thomas, may I have your opinion on this patch? If you are d'accord,
>> I'd upload it to debian/unstable for further testing.
>
> OK, I see that I need to see more clear. The aliases need to be named
> _64 and also need to use the correct type for offsets. I didn't design
> lfs_alias.c to be so smart to derive the correct type from
> LFS_ALIAS_BITS. With your patch, it still would use long arguments,
> which I presume should fail at runtime with mplayer2. We need to
> change the wrapper's argument to reflect whatever is native to the
> platform, not the mpg123 build (it _is_ the same for kFreeBSD).
>
> Please have a read of my musings,
>
> http://scm.orgis.org/view/mpg123/trunk/doc/LARGEFILE ,
>
> and try the attached patch, which reflects the changes I did in mpg123
> trunk, so that you can drop it for mpg123-1.16.0 (which I plan to
> release once I got around fixing some decoder build choice).
>
> I kindly ask everyone concerned to really test this on their platform
> (including linking and running mplayer2 with mpg123 usage, for
> example), as I don't have time to set up test installs for the variants
> right now. I did check that the symbols get defined correctly on my
> Linux system.
The attached patch seems to do the right thing on Debian
kFreeBSD/i386, i386 and amd64. I've therefore uploadedit to Debian
unstable.
Thanks for you efforts!
Cheers
--
regards,
Reinhard
_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
