* Hans-Christoph Steiner <h...@eds.org> [2012-07-02 10:43]:
> 
> On Jul 2, 2012, at 8:37 AM, Jochen Sprickerhof wrote:
> > Great, I've been mailing with Stephen already to get this one into
> > Debian finally. According to [1] there are still some things to sort
> > out:
> > - Did anyone mail upstream regarding the soname already?
> 
> I did email with them on the openni-dev list and they said they'd look into 
> it, but I haven't checked back.  Here's my emails:
> 
> https://groups.google.com/forum/#!msg/openni-dev/GPwUZEueIPA/SoUCATOmVbQJ
> 
> http://openni-discussions.979934.n3.nabble.com/OpenNI-dev-packages-for-Mac-OS-X-Fink-and-Debian-Ubuntu-Mint-td3673546.html

Great, I've created simple patches (attached) to add the soname. As you
are in contact with upstream already, can you ask to include them or at
least get confirmation that they will be included in the next release,
so we can push them for Debian already, maybe?

> > - I really like your way for fink to package both sensor drivers with
> >  proper names. At the moment we have avin2 imported as
> >  primesense-kinect-sensor should we change that?
> 
> Sounds good to me.

Great, thanks for doing it :).

> > Could you import the new upstream versions into the Debian git, so
> > Stephen and me only have to provide small patches?
> > 
> > Cheers Jochen
> 
> Yes, will do.

Thanks as well :).

> .hc

Cheers Jochen
>From 171230d914fe8d5248655af032689ccba0ffdfaf Mon Sep 17 00:00:00 2001
From: Jochen Sprickerhof <joc...@sprickerhof.de>
Date: Tue, 3 Jul 2012 12:28:21 +0200
Subject: [PATCH] Add SONAME to libs

---
 Platform/Linux/Build/Common/CommonCppMakefile |    2 +-
 Platform/Linux/CreateRedist/Redist_OpenNi.py  |    1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/Platform/Linux/Build/Common/CommonCppMakefile b/Platform/Linux/Build/Common/CommonCppMakefile
index c2c4afc..036239a 100644
--- a/Platform/Linux/Build/Common/CommonCppMakefile
+++ b/Platform/Linux/Build/Common/CommonCppMakefile
@@ -78,7 +78,7 @@ ifneq "$(LIB_NAME)" ""
 	ifneq ("$(OSTYPE)","Darwin")
 		LDFLAGS += -Wl,--no-undefined
 		OUTPUT_NAME = lib$(LIB_NAME).so
-		OUTPUT_COMMAND = $(CXX) -o $(OUTPUT_FILE) $(OBJ_FILES) $(LDFLAGS) -shared
+		OUTPUT_COMMAND = $(CXX) -o $(OUTPUT_FILE) $(OBJ_FILES) $(LDFLAGS) -Wl,-soname,${OUTPUT_NAME}.${VERSION} -shared
 	else
 		LDFLAGS += -undefined error
 		OUTPUT_NAME = lib$(LIB_NAME).dylib
diff --git a/Platform/Linux/CreateRedist/Redist_OpenNi.py b/Platform/Linux/CreateRedist/Redist_OpenNi.py
index 594311b..1b7fcb7 100644
--- a/Platform/Linux/CreateRedist/Redist_OpenNi.py
+++ b/Platform/Linux/CreateRedist/Redist_OpenNi.py
@@ -232,6 +232,7 @@ maintenance = re.search(r"define XN_MAINTENANCE_VERSION (\d+)", version_file).gr
 build = re.search(r"define XN_BUILD_VERSION (\d+)", version_file).groups()[0]
 
 version = major + "." + minor + "." + maintenance + "." + build
+MAKE_ARGS += ' VERSION=' + major + '.' + minor
 print "Version:", version
 
 print "Num of compile jobs:", calc_jobs_number()
-- 
1.7.10

>From 5265bdce2b7ff78945d21555362746f5f68ea837 Mon Sep 17 00:00:00 2001
From: Jochen Sprickerhof <joc...@sprickerhof.de>
Date: Tue, 3 Jul 2012 14:35:53 +0200
Subject: [PATCH] Add SONAME to libs

---
 Platform/Linux/Build/Common/CommonCppMakefile |    2 +-
 Platform/Linux/CreateRedist/RedistMaker       |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/Linux/Build/Common/CommonCppMakefile b/Platform/Linux/Build/Common/CommonCppMakefile
index 5a15c82..e21b0b7 100644
--- a/Platform/Linux/Build/Common/CommonCppMakefile
+++ b/Platform/Linux/Build/Common/CommonCppMakefile
@@ -78,7 +78,7 @@ ifneq "$(LIB_NAME)" ""
 	ifneq ("$(OSTYPE)","Darwin")
 		LDFLAGS += -Wl,--no-undefined
 		OUTPUT_NAME = lib$(LIB_NAME).so
-		OUTPUT_COMMAND = $(CXX) -o $(OUTPUT_FILE) $(OBJ_FILES) $(LDFLAGS) -shared
+		OUTPUT_COMMAND = $(CXX) -o $(OUTPUT_FILE) $(OBJ_FILES) $(LDFLAGS) -Wl,-soname,${OUTPUT_NAME}.${VERSION} -shared
 	else
 		LDFLAGS += -undefined error
 		OUTPUT_NAME = lib$(LIB_NAME).dylib
diff --git a/Platform/Linux/CreateRedist/RedistMaker b/Platform/Linux/CreateRedist/RedistMaker
index f812133..4ba785f 100755
--- a/Platform/Linux/CreateRedist/RedistMaker
+++ b/Platform/Linux/CreateRedist/RedistMaker
@@ -67,7 +67,7 @@ rm -rf ../$REDIST_DIR
 # Build Engine
 echo "Building..."
 make -C ../Build clean > /dev/null
-make -j$(calc_jobs_number) -C ../Build
+make -j$(calc_jobs_number) -C ../Build VERSION="$MAJOR.$MINOR"
 
 # create redist folder structure
 echo "Creating redist folder..."
-- 
1.7.10

_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Reply via email to