Your message dated Mon, 21 May 2012 18:29:33 +0000
with message-id <e1swxml-0003p7...@franck.debian.org>
and subject line Bug#670338: fixed in libquicktime 2:1.2.4-3
has caused the Debian Bug report #670338,
regarding libquicktime-dev: FTBFS on hurd.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
670338: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=670338
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: libquicktime-dev
Severity: serious
Tags: patch
Justification: fails to build from source
Dear Maintainer,
* What led up to the situation?
libquicktime FTBFS on hurd-i386 (cf.
http://people.debian.org/~sthibault/graph-top.txt). Building the source from
the git repository fails with :
lqt_codecinfo.c:614:21: error: 'PATH_MAX' undeclared (first use in this
function)
* What exactly did you do (or not do) that was effective (or
ineffective)?
The attached patches fix this issue and should be portable enough to be adopted
upstream.
WBR,
Cyril Roelandt.
-- System Information:
Debian Release: wheezy/sid
APT prefers unreleased
APT policy: (500, 'unreleased'), (500, 'unstable')
Architecture: hurd-i386 (i686-AT386)
Kernel: GNU-Mach 1.3.99/Hurd-0.3
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff --git a/src/lqt_codecinfo.c b/src/lqt_codecinfo.c
index a04b10a..1a95be6 100644
--- a/src/lqt_codecinfo.c
+++ b/src/lqt_codecinfo.c
@@ -601,7 +601,8 @@ static int scan_for_plugins(const char * plugin_dir, lqt_codec_info_t ** databas
{
char * pos;
int ret;
- char * filename;
+ char * filename = NULL;
+ size_t filename_len = 0, new_size = 0;
DIR * directory;
struct dirent * directory_entry;
struct stat status;
@@ -611,8 +612,6 @@ static int scan_for_plugins(const char * plugin_dir, lqt_codec_info_t ** databas
lqt_codec_info_t * video_codecs_end;
lqt_codec_info_t * audio_codecs_end;
- filename = malloc(PATH_MAX * sizeof(char));
-
/* Set the end pointers so we can quickly add codecs after */
@@ -662,6 +661,14 @@ static int scan_for_plugins(const char * plugin_dir, lqt_codec_info_t ** databas
/* Now, the file should be a valid plugin, construct the filename */
+ new_size = strlen(plugin_dir) + strlen(directory_entry->d_name) + 2;
+ if (new_size > filename_len)
+ {
+ filename_len = new_size;
+ filename = realloc(filename, filename_len);
+ if (!filename)
+ exit(EXIT_FAILURE);
+ }
strcpy(filename, plugin_dir);
strcat(filename, "/");
strcat(filename, directory_entry->d_name);
diff --git a/utils/rechunk.c b/utils/rechunk.c
index 1e4be29..0266112 100644
--- a/utils/rechunk.c
+++ b/utils/rechunk.c
@@ -46,7 +46,7 @@ static char ** add_frames_from_file(char ** input_frames,
{
FILE * input;
char * pos;
- char filename[PATH_MAX+10];
+ char *filename = NULL;
input = fopen(list_filename, "r");
if(!input)
@@ -56,7 +56,7 @@ static char ** add_frames_from_file(char ** input_frames,
return (char**)0;
}
- while(fgets(filename, PATH_MAX+10, input))
+ while(getline(&filename, NULL, input) != -1)
{
/* Delete trailing '\n' and '\r' */
@@ -72,7 +72,10 @@ static char ** add_frames_from_file(char ** input_frames,
break;
if(pos == filename)
+ {
+ free(filename);
return input_frames;
+ }
pos--;
}
@@ -83,6 +86,8 @@ static char ** add_frames_from_file(char ** input_frames,
input_frames = realloc(input_frames, sizeof(char*) * *total_input_frames);
input_frames[*total_input_frames - 1] = strdup(filename);
// fprintf(stderr, "Adding file %s\n", input_frames[*total_input_frames - 1]);
+ free(filename);
+ filename = NULL;
}
return input_frames;
}
--- End Message ---
--- Begin Message ---
Source: libquicktime
Source-Version: 2:1.2.4-3
We believe that the bug you reported is fixed in the latest version of
libquicktime, which is due to be installed in the Debian FTP archive:
libquicktime-dev_1.2.4-3_amd64.deb
to main/libq/libquicktime/libquicktime-dev_1.2.4-3_amd64.deb
libquicktime-doc_1.2.4-3_all.deb
to main/libq/libquicktime/libquicktime-doc_1.2.4-3_all.deb
libquicktime2_1.2.4-3_amd64.deb
to main/libq/libquicktime/libquicktime2_1.2.4-3_amd64.deb
libquicktime_1.2.4-3.debian.tar.gz
to main/libq/libquicktime/libquicktime_1.2.4-3.debian.tar.gz
libquicktime_1.2.4-3.dsc
to main/libq/libquicktime/libquicktime_1.2.4-3.dsc
quicktime-utils_1.2.4-3_amd64.deb
to main/libq/libquicktime/quicktime-utils_1.2.4-3_amd64.deb
quicktime-x11utils_1.2.4-3_amd64.deb
to main/libq/libquicktime/quicktime-x11utils_1.2.4-3_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 670...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Alessio Treglia <ales...@debian.org> (supplier of updated libquicktime package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 21 May 2012 19:40:32 +0200
Source: libquicktime
Binary: libquicktime2 libquicktime-dev libquicktime-doc quicktime-utils
quicktime-x11utils
Architecture: source all amd64
Version: 2:1.2.4-3
Distribution: unstable
Urgency: low
Maintainer: Debian Multimedia Maintainers
<pkg-multimedia-maintainers@lists.alioth.debian.org>
Changed-By: Alessio Treglia <ales...@debian.org>
Description:
libquicktime-dev - library for reading and writing Quicktime files
(development)
libquicktime-doc - library for reading and writing Quicktime files
(documentation)
libquicktime2 - library for reading and writing Quicktime files
quicktime-utils - library for reading and writing Quicktime files (utilities)
quicktime-x11utils - library for reading and writing Quicktime files (x11
utilities)
Closes: 670338
Changes:
libquicktime (2:1.2.4-3) unstable; urgency=low
.
* Team upload.
* debian/patches/11-path_max.patch (Closes: #670338):
- Avoid the use of PATH_MAX to allow building quicktime on hurd.
- utils/rechunk.c: Don't use getline() unconditionally as it
needs GNU extensions.
Checksums-Sha1:
cebced5a10a5fb99395b20055a5e6fa302da0c84 2695 libquicktime_1.2.4-3.dsc
8754bbc2761e4757ffbe968950f9e56afb979123 14994
libquicktime_1.2.4-3.debian.tar.gz
046682b393c71c3e980e93c6a1beb0658aeac0e7 192854
libquicktime-doc_1.2.4-3_all.deb
c18d87e49e5f34a9615be4ccc4023876aa222f13 359044 libquicktime2_1.2.4-3_amd64.deb
85ceda3734430fb9b0347e1ce66875f17cdc8994 44688
libquicktime-dev_1.2.4-3_amd64.deb
fd28e22e4459b6ab3a5c5810a705dba6d07e5f87 38630
quicktime-utils_1.2.4-3_amd64.deb
1ad4199e1a286129f1ac825616a66e9fe5d133a7 47514
quicktime-x11utils_1.2.4-3_amd64.deb
Checksums-Sha256:
0f32b1ac8744e6e6915b89642981c3b9f36f623a4c7813677ca2d63408d9e99f 2695
libquicktime_1.2.4-3.dsc
1eb87e064cbb6144f17956b1ce996e57d78cccef561874031621dcf75ed03506 14994
libquicktime_1.2.4-3.debian.tar.gz
2e5e0c27fec83193367ec4f55a8a40eb6d72510f7c1b8291727a70902246abb5 192854
libquicktime-doc_1.2.4-3_all.deb
1af911203eaf38880dd64ac9a98624ceb7ef27408b317c1c3688f7a96b249b2e 359044
libquicktime2_1.2.4-3_amd64.deb
86b2f513c762c55bdd32e6834cde95b66699686b51d16106a13c133e5e7385c7 44688
libquicktime-dev_1.2.4-3_amd64.deb
5745aebbdbc3a35448bb139ffac0dac0c734400b60daf1954f60776cd2b3ce8a 38630
quicktime-utils_1.2.4-3_amd64.deb
5e74acfa0188317387500273a1d949354ce30b2f16116d26d86d9ecefcd18697 47514
quicktime-x11utils_1.2.4-3_amd64.deb
Files:
8eab7ff71a206ae10db7d5837222d631 2695 devel optional libquicktime_1.2.4-3.dsc
a617f8fb54f917b934b5836e643261d4 14994 devel optional
libquicktime_1.2.4-3.debian.tar.gz
3135e3b211074fd4de140dc01b0ee075 192854 doc optional
libquicktime-doc_1.2.4-3_all.deb
c82b1b99e9f95b0625ecf9eb893ec18b 359044 libs optional
libquicktime2_1.2.4-3_amd64.deb
ef230c0a427ffee174ce669f565666ee 44688 libdevel optional
libquicktime-dev_1.2.4-3_amd64.deb
eaa67d1831738d14fa3f8c62ba9c14f1 38630 utils extra
quicktime-utils_1.2.4-3_amd64.deb
1c89f7fc0dc0c8840cb629c80d52ade6 47514 utils extra
quicktime-x11utils_1.2.4-3_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iQIcBAEBCgAGBQJPuoD6AAoJEOikiuUxHXZaYpoQAJjTuI8C5ZmQc8sDyp/Pndlk
VLjxyAL4mWoTWFFA7uCfPIo7yNP20Ilnxpt7dXwbM2n6MYsYCT5wXcc6BRI8OTvE
r4gNqOuXQHyTnw+SH06xzTFbTjgqBDXNy9K1M6l+IzJqT8+sMOzPBPI8DiHyjlYs
o4P44BwkWhKme815d0Hj0DT0BGoMZHdTtOQHmaiKH+7Fo70acyIiorKrPL54o1g7
tiLohZywU17ldDvuvKGkJDZYL+CiP0Y4arlKZ2tMrmzb3OjvNqGKacqSzh6DXwXN
lPr55X02Bk/JZDfMIsb7XsAPP0WA4ugkYWhco2Wv+1gDJjuUoal+VoV4g6Qrtomw
EfD8AMugMFhKut8uVn4/tcpZYhIvDWlLriVgkWoQ0kDz9P7pPILeYnx1cKxeCoxu
G2SuNkxO7heXt/5Mdmw/MRoxtVNlrDAkG8ZQNb/MPefJljf+9fbmyFpP3xuF8FmF
6a1WA7s04YcUjKqJFcUvgZPtGulyvgs8zO44koY2qKkiXJxaCYgjahGSOQpihDHp
7pT7R3lkVgxcp9YE52ruBcvRe4VaVRXG1PAcGOgDrqrAenlIEmUmsMDrfqtFW+iW
A9mvr0mh4tbG8b5e0v+pkJD1h4wn+km+Y24s4T53bAdVE5YGIpQzgmemBxfHKAv7
VVW1c6lXlDrbMOaQ14Uj
=MITy
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
