Package: easytag
Version: 2.1.7-1
Severity: normal
Tags: patch
Forwarded: easytag-mail...@lists.sourceforge.net

easy tag crashes when one searches due to a buffer overflow in misc.c
See the ubuntu bug:
https://bugs.launchpad.net/ubuntu/+source/easytag/+bug/907806

Attached a bug fixing the issue by simply expanding the array to what
seems the correct size.
Description: fix out of bound array access
 The list has 15 columns
Author: Julian Taylor <jtay...@ubuntu.com>
Bug-Ubuntu: https://bugs.launchpad.net/bugs/907806

--- easytag-2.1.7.orig/src/misc.c
+++ easytag-2.1.7/src/misc.c
@@ -2462,16 +2462,18 @@ void Search_File (GtkWidget *search_butt
 
 void Add_Row_To_Search_Result_List(ET_File *ETFile,const gchar *string_to_search)
 {
-    gchar *SearchResultList_Text[14]; // Because : 14 columns to display
-    gint SearchResultList_Weight[14] = {PANGO_WEIGHT_NORMAL, PANGO_WEIGHT_NORMAL,
+    gchar *SearchResultList_Text[15]; // Because : 15 columns to display
+    gint SearchResultList_Weight[15] = {PANGO_WEIGHT_NORMAL, PANGO_WEIGHT_NORMAL,
                                         PANGO_WEIGHT_NORMAL, PANGO_WEIGHT_NORMAL,
                                         PANGO_WEIGHT_NORMAL, PANGO_WEIGHT_NORMAL,
                                         PANGO_WEIGHT_NORMAL, PANGO_WEIGHT_NORMAL,
                                         PANGO_WEIGHT_NORMAL, PANGO_WEIGHT_NORMAL,
                                         PANGO_WEIGHT_NORMAL, PANGO_WEIGHT_NORMAL,
-                                        PANGO_WEIGHT_NORMAL, PANGO_WEIGHT_NORMAL};
-    GdkColor *SearchResultList_Color[14] = {NULL, NULL, NULL, NULL, NULL, NULL, NULL,
-                                            NULL, NULL, NULL, NULL, NULL, NULL, NULL};
+                                        PANGO_WEIGHT_NORMAL, PANGO_WEIGHT_NORMAL,
+                                        PANGO_WEIGHT_NORMAL};
+    GdkColor *SearchResultList_Color[15] = {NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+                                            NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+                                            NULL};
     gchar *track, *track_total;
     gboolean case_sensitive;
     gint column;

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Reply via email to