Am 18.03.2012 00:42, schrieb Andres Mejia:
libdvdcss-installer can be found at
http://anonscm.debian.org/gitweb/?p=pkg-multimedia/libdvdcss-installer.git
Any comments/concerns?
I like the idea behind this script and as writing it was on my TODO
list anyway, I like the fact that you actually started writing it
first. ;)
However, I see a problem in callign "apt-get" in the
uninstall_libdvdcss() function and then calling "libdvdcss-installer
--remove" in the prerm script. This will run apt-get while apt-get is
still be active and thus might lead to confusion/fail.
Furthermore, I think the first three checks in check_libdvdcss() are
pretty redundant. We should only check if libdvdcss.so.2 is in
LD_LIBRARY_PATH. If it isn't there, it's invisible to the dynamic
linker anyway.
Apart from this, good job. ;)
- Fabiam
_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
