Package: ladish Version: 0.3-4 Severity: normal Tags: patch
Ladish tries to start terminal-bound commands as <terminal> -e 'command args'. In general, "x-terminal-emulator -e" expects an executable + arguments, NOT a command string, as daemon/loader.c provides. The attached (if trivial) patch fixes that. More generally, this fix has the benefit of telling the terminal emulator which shell to use (the one configured in ladish), as opposed to letting it decide on its own. -- System Information: Debian Release: squeeze/sid APT prefers lucid-updates APT policy: (500, 'lucid-updates'), (500, 'lucid-security'), (500, 'lucid-proposed'), (500, 'lucid-backports'), (500, 'lucid') Architecture: i386 (i686) Kernel: Linux 2.6.38-5.dmz.1-liquorix-686 (SMP w/2 CPU cores; PREEMPT) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages ladish depends on: ii la 1:1.0~rc2+20100724.gitf4d4a2-1~lucid2 set of tools to control and monito ii li 2.3.20-2build1 Library of functions for 2D graphi ii li 1.30.0-0ubuntu2.1 The ATK accessibility toolkit ii li 2.11.1-0ubuntu7.8 Embedded GNU C Library: Shared lib ii li 1.8.10-2ubuntu1 The Cairo 2D vector graphics libra ii li 1.8.4-0ubuntu1 C++ wrappers for Cairo (shared lib ii li 1.2.16-2ubuntu4.2 simple interprocess messaging syst ii li 0.84-1 simple interprocess messaging syst ii li 2.0.1-7ubuntu1 XML parsing C library - runtime li ii li 0.7.1-0ubuntu1~lucid1 interactive widget for “boxes and ii li 2.8.0-2ubuntu1 generic font configuration library ii li 2.3.11-1ubuntu2.4 FreeType 2 font engine, shared lib ii li 1:4.5.1-7ubuntu2danmppa1~lucid1 GCC support library ii li 2.24.1-0ubuntu1 The GLib library of C routines ii li 2.24.2-0ubuntu1 C++ wrapper for the GLib toolkit ( ii li 2.30.1-0ubuntu1 A powerful object-oriented display ii li 2.26.0-1build1 C++ wrappers for libgnomecanvas2 ( ii li 2.20.1-0ubuntu2 The GTK+ graphical user interface ii li 1:2.20.3-0ubuntu1 C++ wrappers for GTK+ (shared libr ii li 0.120 Dummy package to quench libjack0 d ii li 1.28.0-0ubuntu2.2 Layout and rendering of internatio ii li 2.26.2-0ubuntu1 C++ Wrapper for pango (shared libr ii li 2.2.4.2-1 type-safe Signal Framework for C++ ii li 4.5.1-7ubuntu2danmppa1~lucid1 The GNU Standard C++ Library v3 ii li 2.17.2-0ubuntu1.10.04.2 Universally Unique ID library ladish recommends no packages. ladish suggests no packages. -- no debconf information
>From 5e07f29e9d863608581093313a4a780d38f1a3db Mon Sep 17 00:00:00 2001 From: Dan A. Muresan <danm...@gmail.com> Date: Sat, 7 May 2011 14:01:14 +0300 Subject: [PATCH] Fix in-terminal execution for non-xterm Forwarded: http://ladish.org/ticket/179 --- daemon/loader.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/daemon/loader.c b/daemon/loader.c index ad9b983..d8c7fa1 100644 --- a/daemon/loader.c +++ b/daemon/loader.c @@ -317,7 +317,7 @@ loader_exec_program( argv[i++] = "-e"; } - if (!run_in_terminal || strchr(commandline, '$') != NULL) + if (!run_in_terminal || 1 /* -e expects an executable not a shell command */) { if (!conf_get(LADISH_CONF_KEY_DAEMON_SHELL, argv + i)) { -- 1.7.0.4
_______________________________________________ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
