On Mon, Mar 14, 2011 at 11:32:18AM +0200, Andriy Beregovenko wrote:
> > - debian/init.d should be named debian/[package].init (have a look at the
> > dh_installinit manpage)
> Ok, I fix this now :)
Good.
> > - debian/copyright looks wrong. There are many files licensed BSD-3-clause
> > and zlib/libpng. You should include them in the copyright as well.
> > Also, you may want to convert d/copyright to use the DEP5 format [0]
> > (not strictly needed, but very appreciated)
> I do not see any BSD-licensed files
% licensecheck -R --copyright . | grep BSD
./common/src/platform/solaris/timegm.cpp: BSD (3 clause)
./common/src/platform/windows/strncasecmp.cpp: BSD (3 clause)
./common/src/platform/windows/timegm.cpp: BSD (3 clause)
./common/src/platform/windows/strptime.cpp: BSD (3 clause)
./common/src/platform/android/timegm.cpp: BSD (3 clause)
Look at these files.
> > - Missing debian/watch file (I'm not sure if this can be fixed)
> Right now watch file is not added cause original project do not have any
> release and have every day commits. So, imo, there is not any practical
> reason to track version.
Agree.
> > - If you don't use the Vcs-* fields in debian/control you should remove
> > them (they are currently commented-out)
> Ok.
> > - There are many lintian I, P and even E tags. Please fix them (and use
> > lintian -IE --pedantic to check your package). For example:
> >
> > P: crtmpserver source: source-contains-svn-control-dir ...
> > E: crtmpserver: copyright-should-refer-to-common-license-file-for-gpl ..
> > E: crtmpserver: possible-gpl-code-linked-with-openssl ...
> > I: crtmpserver: copyright-with-old-dh-make-debian-copyright ...
> > I: crtmpserver: spelling-error-in-binary ...
> > [...]
> I'm novice in debian policies and need some help as for
> "possible-gpl-code-linked-with-openssl".
This means that a GPLed software is linking against openssl (which has a
gpl-incompatible license) and is, therefore, illegal. See [0].
>From the d/copyright of the latest version of the package I see:
GPL-3.0+ with OpenSSL exception
What does it mean? Where is the "OpenSSL exception" documented? In the
copyright you should point to the proper documentation.
> Also what version of dh_make i must
> to use ? Currently I use 0.58 (squeeze).
It's not a matter of which dh-make version you use. It simply says that the
debian/copyright template, which has been created by an older version of
dh-make have to be updated. Now you use DEP5 so there is no problem (note
that newer dh-make version from sid creates a DEP5 template).
> > Please also consider joining the Debian Multimedia Maintainers team to
> > (co-)maintain this and (when you'll feel comfortable) other
> > multimedia-related packages.
> > In the team you'll find valuable mentors that'll guide and help you in
> > the process of maintaining this and other (multimedia-related) packages.
> >
> > Have a look at the team's wiki [0], if you agree with our policies (e.g.
> > using git to co-maintain packages, using quilt for managing patches, etc...)
> > you are very welcome. :)
> >
> > (if you accept let us know your account name on alioth.debian.org so that I
> > or someone else can add you to the pkg-multimedia project and setup a git
> > repository for your package)
> Yes, I agree and want to join your team :)
> My nick is jet-guest on alioth.
I added you to the group on alioth.d.o :)
Also note that I'm not a DD (maybe I should have said this before),
therefore I can't upload your package, but I am sure you'll find someone
in the team to do so (when the package will be in a proper shape, of
course).
On Mon, Mar 14, 2011 at 01:31:27PM +0200, Andriy Beregovenko wrote:
> I update package and looks like lintian clean(except no-upstream-changelog
> and some info as for libs).
Not quite true, I still see many spelling-error-in-binary. You should
patch the source files fixing those spelling errors.
I've also spotted some more issues:
- In debian/control the long description starts with a '.'. It is not
necessary (you can remove it).
- The package includes and compiles the whole liblua sources. It should
rely on libraries provided by the system rather than build and link
against local copies. You should patch the building system if possible, to
use the Debian provided liblua (from the liblua5.1-0-dev and liblua5.1-0
packages).
- Under applications/applestreamingclient/flex/html-template there is a
playerProductInstall.swf binary file, which is not in the "preferred form
of modification". Proper sources should be provided, or the file should
be removed by the orig.tar archive (there may be other files in the same
condition, please have a closer look and fix/remove all the problematic
files).
I've also noticed that the empty debian/docs file is still there (please
remove it).
Cheers
[0] http://ftp-master.debian.org/REJECT-FAQ.html
--
perl -E'$_=q;$/= @{[@_]};and s;\S+;<inidehG ordnasselA>;eg;say~~reverse'
_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
