Your message dated Tue, 20 Aug 2019 09:05:53 +0000
with message-id <[email protected]>
and subject line Bug#797169: fixed in mjpegtools 1:2.1.0+debian-6
has caused the Debian Bug report #797169,
regarding mjpegtools: FTBFS with x32 because of unused SIMD code remains
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
797169: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797169
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: mjpegtools
Version: 1:2.1.0+debian-3
Severity: important
Tags: patch
Hi,
your package configures with --disable-simd-accel but the upstream
code fails to fully disable all related functions, leading to some
asm code still being compiled, which fails on x32 due to its model.
The attached patch fully disables the (unused anyway!) code making
it buildable on x32. I tested on i386, where it still builds, too.
Please apply and forward upstream. Thanks!
-- System Information:
Debian Release: stretch/sid
APT prefers unreleased
APT policy: (500, 'unreleased'), (500, 'buildd-unstable'), (500, 'unstable')
Architecture: x32 (x86_64)
Foreign Architectures: i386, amd64
Kernel: Linux 4.1.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/lksh
Init: sysvinit (via /sbin/init)
diff -Nru mjpegtools-2.1.0+debian/debian/changelog mjpegtools-2.1.0+debian/debian/changelog
--- mjpegtools-2.1.0+debian/debian/changelog 2014-12-08 11:08:24.000000000 +0100
+++ mjpegtools-2.1.0+debian/debian/changelog 2015-08-28 10:37:41.000000000 +0200
@@ -1,3 +1,10 @@
+mjpegtools (1:2.1.0+debian-3+x32.1) unreleased; urgency=medium
+
+ * Non-maintainer upload.
+ * New patch to disable unused CPU detection
+
+ -- Thorsten Glaser <[email protected]> Fri, 28 Aug 2015 10:37:14 +0200
+
mjpegtools (1:2.1.0+debian-3) unstable; urgency=medium
[ Alessio Treglia ]
diff -Nru mjpegtools-2.1.0+debian/debian/patches/18_no-simd.patch mjpegtools-2.1.0+debian/debian/patches/18_no-simd.patch
--- mjpegtools-2.1.0+debian/debian/patches/18_no-simd.patch 1970-01-01 01:00:00.000000000 +0100
+++ mjpegtools-2.1.0+debian/debian/patches/18_no-simd.patch 2015-08-28 10:37:06.000000000 +0200
@@ -0,0 +1,76 @@
+Description: Test for SIMD instructions at run-time only if configured.
+ Do not attempt to use e.g. CPU detection if the result does not matter
+ anyway; fixes FTBFS on architectures with slightly different asm, such
+ as x32.
+Author: Thorsten Glaser <[email protected]>
+Forwarded: no
+Bug-Debian: coming
+Last-Update: 2015-08-28
+
+--- a/configure.ac
++++ b/configure.ac
+@@ -386,6 +386,8 @@ AC_SUBST(PROGRAM_NOPIC)
+
+ if test "$enable_simd_accel" != "false" -a "$enable_simd_accel" != "no"
+ then
++ AC_DEFINE(HAVE_SIMD_ACCEL, 1, [use SIMD multimedia instructions if possible])
++
+ if test x$have_x86cpu = xtrue
+ then
+ AC_MSG_CHECKING([if C compiler accepts inline MMX assembly])
+--- a/utils/cpu_accel.c
++++ b/utils/cpu_accel.c
+@@ -38,7 +38,7 @@
+ #include <malloc.h>
+ #endif
+
+-#ifdef HAVE_ALTIVEC
++#if defined(HAVE_SIMD_ACCEL) && defined(HAVE_ALTIVEC)
+ extern int altivec_copy_v0();
+ #endif
+
+@@ -77,7 +77,7 @@ extern int altivec_copy_v0();
+
+ static char *parse_next(char **, const char *);
+
+-#ifdef HAVE_X86CPU
++#if defined(HAVE_SIMD_ACCEL) && defined(HAVE_X86CPU)
+
+ /* Some miscelaneous stuff to allow checking whether SSE instructions cause
+ illegal instruction errors.
+@@ -208,7 +208,7 @@ static int x86_accel (void)
+ #endif
+
+
+-#ifdef HAVE_ALTIVEC
++#if defined(HAVE_SIMD_ACCEL) && defined(HAVE_ALTIVEC)
+ /* AltiVec optimized library for MJPEG tools MPEG-1/2 Video Encoder
+ * Copyright (C) 2002 James Klicman <[email protected]>
+ *
+@@ -263,7 +263,7 @@ noAltiVec:
+
+ int32_t cpu_accel (void)
+ {
+-#ifdef HAVE_X86CPU
++#if defined(HAVE_SIMD_ACCEL) && defined(HAVE_X86CPU)
+ static int got_accel = 0;
+ static int accel;
+
+@@ -273,7 +273,7 @@ int32_t cpu_accel (void)
+ }
+
+ return accel;
+-#elif defined(HAVE_ALTIVEC)
++#elif defined(HAVE_SIMD_ACCEL) && defined(HAVE_ALTIVEC)
+ return detect_altivec();
+ #else
+ return 0;
+@@ -356,7 +356,7 @@ void *bufalloc( size_t size )
+
+ if( !bufalloc_init )
+ {
+-#ifdef HAVE_X86CPU
++#if defined(HAVE_SIMD_ACCEL) && defined(HAVE_X86CPU)
+ if( (cpu_accel() & (ACCEL_X86_SSE|ACCEL_X86_3DNOW)) != 0 )
+ {
+ simd_alignment = 64;
diff -Nru mjpegtools-2.1.0+debian/debian/patches/series mjpegtools-2.1.0+debian/debian/patches/series
--- mjpegtools-2.1.0+debian/debian/patches/series 2014-12-08 09:30:45.000000000 +0100
+++ mjpegtools-2.1.0+debian/debian/patches/series 2015-08-28 10:35:06.000000000 +0200
@@ -11,3 +11,4 @@
15_fix_qttoy4m_linking.diff
16_fix_ftbfs_format_security.patch
17_hurd.patch
+18_no-simd.patch
--- End Message ---
--- Begin Message ---
Source: mjpegtools
Source-Version: 1:2.1.0+debian-6
We believe that the bug you reported is fixed in the latest version of
mjpegtools, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Fabian Greffrath <[email protected]> (supplier of updated mjpegtools package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 20 Aug 2019 10:21:46 +0200
Source: mjpegtools
Architecture: source
Version: 1:2.1.0+debian-6
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <[email protected]>
Changed-By: Fabian Greffrath <[email protected]>
Closes: 772354 794751 797169 829312 934984
Changes:
mjpegtools (1:2.1.0+debian-6) unstable; urgency=medium
.
* Team upload.
.
[ Ondřej Nový ]
* d/control: Set Vcs-* to salsa.debian.org
.
[ Felipe Sateler ]
* Change maintainer address to [email protected]
.
[ Fabian Greffrath ]
* Remove myself from Uploaders
* Add "Recommends: mencoder" to the mjpegtools package for the lav2avi
script to work (Closes: #794751).
* Extend 08_use_bash.patch to also run the lav2avi script with /bin/bash,
as it contains bashisms (Closes: #772354).
* Remove Maia Kozheva from Uploaders (Closes: #829312).
.
[ Ondřej Nový ]
* d/watch: Use https protocol
* Use debhelper-compat instead of debian/compat
.
[ Jens Reyer ]
* Mark shared libraries and development packages as "Multi-Arch: same"
(Closes: #934984).
.
[ Thorsten Glaser ]
* New patch to disable unused CPU detection
(Closes: #797169).
Checksums-Sha1:
8694ab27e5d892653d988783d303fc4013bcdbcb 2673 mjpegtools_2.1.0+debian-6.dsc
fd4eb0e9d0042c926f523a242893ccab6ec737fd 12436
mjpegtools_2.1.0+debian-6.debian.tar.xz
30f9ff89ae9740fe180ed25dd8eccd1760fbf405 18946
mjpegtools_2.1.0+debian-6_amd64.buildinfo
Checksums-Sha256:
f87447b38127628474a553107180451a4ec3dac6753f2d5c116c8a70fff095f8 2673
mjpegtools_2.1.0+debian-6.dsc
ac5b669d40bbd79d94a7f8d68bd063104f05d197d992c69dd6a22c0946913f19 12436
mjpegtools_2.1.0+debian-6.debian.tar.xz
5c6aebfe68d19357e55c3b0e007a0e454d577223d1da50633512e6d45627ca15 18946
mjpegtools_2.1.0+debian-6_amd64.buildinfo
Files:
0b4d1ecdfb8e6e7bfa872e7dc5fe68b6 2673 video optional
mjpegtools_2.1.0+debian-6.dsc
f195208d2d9aa04bbd8983b33cb33651 12436 video optional
mjpegtools_2.1.0+debian-6.debian.tar.xz
5e48aac46cb91f2106a40524c5b7dcf6 18946 video optional
mjpegtools_2.1.0+debian-6_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJGBAEBCAAwFiEEIsF2SKlSa4TfGRyWy+qOlwzNWd8FAl1bsdQSHGZhYmlhbkBk
ZWJpYW4ub3JnAAoJEMvqjpcMzVnfOs8QAOaR/evMYlSVOE0UmwCKO7U1a2oqnv43
9IZ6pf86QrxUTWB9V6rRCV89cYYglk5VBq+Httn6iUKsupNA+jzL7keUDGpZ9mSA
S2C+zKy9vXn6zbzbDlar7iwleZfQf+u3b/+OREPtPb97KuMCRoE9+GbPQamE1L+/
6sFlKprkVHlCMV3j7EVt5fbWYB1gH46HgLOZrk9rm9oCJ5VRiv7aGLTjHQLMpv6I
Uqnl7RBSqha58Px2v8TNqTi15foB14JWMh/g7JzYUP80Ci0Y0iGzx1bDleOKLAYk
tTG9M09v5UgVEhDSoKHSzxHxYxy6tROkcBHGWqaF9ZaJENE7bInUC7hhgmiJJeB4
jUiEj8n2kc79na+ocxYY9lHKA0MRpMvHOsPMTFD4Jx6vAToVpN7WvxS+3m12VXHk
tX6b0QzvESVoJzwXrjeCyfn0bGu3j9s3ly2CWZmdNZalA9kfmmCgDU81WJKtQq/v
drnv+QgfRozuSWbvH7l6A0EOY4Kl4Bg1i8BK9YRFs0EnxurlLdhiNQInfOQUDPCM
jnnVDGxMsMrnAEaSSx0aHo0OMyDwEm0gcniWePuuDHAywn4g06Ft+JxGZC35c9JE
G1p0feUXhGXnMWFgW78gjP5Y9WjEtpod8uVYGiyOo6RJ9wouP24P6N0HKzohnojZ
M5a9DbH+0vqq
=+08g
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
pkg-multimedia-maintainers mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
