Hi Emilien, On Wed, 2012-10-31 at 15:49 +0100, Emilien Klein wrote: > 2012/10/29 Marcelo Jorge Vieira <[email protected]>: > > Hi Emilien, > > > > On Mon, 2012-10-29 at 15:53 +0100, Emilien Klein wrote: > >> Hi team, > >> > >> 2012/9/30 Emilien Klein <[email protected]>: > >> > Hi JS team, > >> > > >> > I've updated jquery-lazyload's git repo [0] with its latest version > >> > 1.8.0. > >> > It would be nice if one of you could review it, and if everything is > >> > OK, upload it. > >> > >> Could somebody have a look at this new version, and upload it? > > > > I will do it. > > Thanks Marcelo. > +Emilien
My review:
1) Minified files:
1.1) source tarball: You must remove all minified files
(jquery.lazyload.min.js and jquery.scrollstop.min.js)
and repack the tarball.
1.2) changelog: Add suffix +dfsg to the upstream version number:
1.8.0+dfsg-1;
1.3) watch: Mangle the upstream version;
1.4) rules: Minify jquery.lazyload.js and jquery.scrollstop.js
2) README.Debian
2.1) I guess you forgot it:
<img class="lazy" src="img/grey.gif"
data-original="img/example.jpg" width="640" heigh="480">
3) examples:
3.1) Would be interesting you install the examples
Cheers,
--
Marcelo Jorge Vieira
xmpp:[email protected]
http://metaldot.alucinados.com
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Pkg-javascript-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
