[Pkg-javascript-devel] Bug#1036259: Bug#1036259: moment-timezone.js: FTBFS in testing: make[1]: *** [debian/rules:28: execute_before_dh_auto_configure] Error 1

Sun, 28 May 2023 09:09:13 -0700 

On 5/28/23 19:56, gregor herrmann wrote:

On Thu, 18 May 2023 09:00:03 +0200, Lucas Nussbaum wrote:


During a rebuild of all packages in testing (bookworm), your package failed
to build on amd64.


Relevant part (hopefully):

  debian/rules binary
dh binary
    dh_update_autotools_config
    dh_autoreconf
    debian/rules execute_before_dh_auto_configure
make[1]: Entering directory '/<<PKGBUILDDIR>>'
# Fail the build if the tzdata package does not match TZVER.
grep -q '^# version 2022g$' /usr/share/zoneinfo/tzdata.zi
make[1]: *** [debian/rules:28: execute_before_dh_auto_configure] Error 1


This looked reasonably easy to fix (cf. attached patch), but the
tests fail as follows:


Hi,
I fixed it in salsa (needs an update to import 2023 data). I'm waiting for Martina review who maintains it. 

Cheers,
Yadd


#v+
Running "nodeunit:countries" (nodeunit) task
Testing countries.jsFF

countries - zone_countries
Error: [] deepEqual [ 'CA' ]
at Object.deepEqual (/usr/share/nodejs/nodeunit/lib/types.js:83:39)
at Object.zone_countries (tests/countries/countries.js:230:8)
at Object.<anonymous> (/usr/share/nodejs/nodeunit/lib/core.js:236:16)
at Object.<anonymous> (/usr/share/nodejs/nodeunit/lib/core.js:236:16)
at /usr/share/nodejs/nodeunit/lib/core.js:236:16
at Object.exports.runTest (/usr/share/nodejs/nodeunit/lib/core.js:70:9)
at /usr/share/nodejs/nodeunit/lib/core.js:118:25
at /usr/share/javascript/async/async.js:665:13
at iterate (/usr/share/javascript/async/async.js:149:13)
at async.eachSeries (/usr/share/javascript/async/async.js:165:9)



countries - zone_countries
Error: [ 'US' ] deepEqual [ 'UM', 'US' ]
at Object.deepEqual (/usr/share/nodejs/nodeunit/lib/types.js:83:39)
at Object.zone_countries (tests/countries/countries.js:552:8)
at Object.<anonymous> (/usr/share/nodejs/nodeunit/lib/core.js:236:16)
at Object.<anonymous> (/usr/share/nodejs/nodeunit/lib/core.js:236:16)
at /usr/share/nodejs/nodeunit/lib/core.js:236:16
at Object.exports.runTest (/usr/share/nodejs/nodeunit/lib/core.js:70:9)
at /usr/share/nodejs/nodeunit/lib/core.js:118:25
at /usr/share/javascript/async/async.js:665:13
at iterate (/usr/share/javascript/async/async.js:149:13)
at async.eachSeries (/usr/share/javascript/async/async.js:165:9)



countries - country_zones
Actual:
   [
     'America/Atikokan',      'America/Blanc-Sablon',
     'America/Cambridge_Bay', 'America/Creston',
     'America/Dawson',        'America/Dawson_Creek',
     'America/Edmonton',      'America/Fort_Nelson',
     'America/Glace_Bay',     'America/Goose_Bay',
     'America/Halifax',       'America/Inuvik',
     'America/Iqaluit',       'America/Moncton',
     'America/Panama',        'America/Phoenix',
     'America/Puerto_Rico',   'America/Rankin_Inlet',
     'America/Regina',        'America/Resolute',
     'America/St_Johns',      'America/Swift_Current',
     'America/Toronto',       'America/Vancouver',
     'America/Whitehorse',    'America/Winnipeg'
   ]
Operator:
   deepEqual
Expected:
   [
     'America/Atikokan',      'America/Blanc-Sablon',
     'America/Cambridge_Bay', 'America/Creston',
     'America/Dawson',        'America/Dawson_Creek',
     'America/Edmonton',      'America/Fort_Nelson',
     'America/Glace_Bay',     'America/Goose_Bay',
     'America/Halifax',       'America/Inuvik',
     'America/Iqaluit',       'America/Moncton',
     'America/Panama',        'America/Phoenix',
     'America/Puerto_Rico',   'America/Rankin_Inlet',
     'America/Regina',        'America/Resolute',
     'America/St_Johns',      'America/Swift_Current',
     'America/Toronto',       'America/Vancouver',
     'America/Whitehorse',    'America/Winnipeg',
     'America/Yellowknife'
   ]
at Object.deepEqual (/usr/share/nodejs/nodeunit/lib/types.js:83:39)
at Object.country_zones (tests/countries/countries.js:646:8)
at Object.<anonymous> (/usr/share/nodejs/nodeunit/lib/core.js:236:16)
at Object.<anonymous> (/usr/share/nodejs/nodeunit/lib/core.js:236:16)
at /usr/share/nodejs/nodeunit/lib/core.js:236:16
at Object.exports.runTest (/usr/share/nodejs/nodeunit/lib/core.js:70:9)
at /usr/share/nodejs/nodeunit/lib/core.js:118:25
at /usr/share/javascript/async/async.js:665:13
at iterate (/usr/share/javascript/async/async.js:149:13)
at /usr/share/javascript/async/async.js:160:25



countries - country_zones
Actual:
   [
     'Pacific/Midway',
     'Pacific/Pago_Pago',
     'Pacific/Tarawa',
     'Pacific/Wake'
   ]
Operator:
   deepEqual
Expected:
   [
     'Pacific/Honolulu',
     'Pacific/Midway',
     'Pacific/Pago_Pago',
     'Pacific/Tarawa',
     'Pacific/Wake'
   ]
at Object.deepEqual (/usr/share/nodejs/nodeunit/lib/types.js:83:39)
at Object.country_zones (tests/countries/countries.js:839:8)
at Object.<anonymous> (/usr/share/nodejs/nodeunit/lib/core.js:236:16)
at Object.<anonymous> (/usr/share/nodejs/nodeunit/lib/core.js:236:16)
at /usr/share/nodejs/nodeunit/lib/core.js:236:16
at Object.exports.runTest (/usr/share/nodejs/nodeunit/lib/core.js:70:9)
at /usr/share/nodejs/nodeunit/lib/core.js:118:25
at /usr/share/javascript/async/async.js:665:13
at iterate (/usr/share/javascript/async/async.js:149:13)
at /usr/share/javascript/async/async.js:160:25


Warning: 4/841 assertions failed (48ms) Use --force to continue.

Aborted due to warnings.
dh_auto_test: error: /bin/sh -ex debian/tests/pkg-js/test returned exit code 6
make: *** [debian/rules:24: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
#v-

Apparently there's more work needed to adjust the test suite (list of
timezones) to tzdata 2023c …


Cheers,
gregor





--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Reply via email to