My patch actually replaces the asmcrypto.all.js in package.json to asmcrypto.all.es8.js.

My patch also actually builds asmcrypto.all.es8.js but it wasn't being installed before, I've modified debian/watch to install it.

I excluded asmcrypto.all.js and a few other bundles from the build because those are either cjs or browser bundles, whereas my package needs only the es8 bundle.

 

Sent from Mail for Windows

 

From: Yadd
Sent: Friday, March 10, 2023 3:49 AM
To: Sandra Uwah
Cc: pkg-_javascript_-devel@alioth-lists.debian.net
Subject: Re: [Pkg-_javascript_-devel] RFS - node-openpgp-asmcrypto.js

 

On 3/10/23 02:05, Sandra Uwah wrote:

> Hello,

>

> Requesting sponsorship for the package node-openpgp-asmcrypto.js

>

> Package details;

>

> Package version: 2.3.3~0

>

> Package repo: https://salsa.debian.org/sandra_uwah/node-openpgp-asmcrypto.js

>

> I have made the package lintian clean and have built in a clean

> environment using sbuild.

 

Hi,

 

* debian/watch seems wrong (uscan found nothing)

* package.json propose a CommonJS file (asmcrypto.all.js) which is not

   built with your patch, why did you drop it?

* please ajust package.json#files or .npmignore: only dist/ and

   ./asmcrypto*.js are needed

 

Cheers,

Yadd

 

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Reply via email to