On Wed, Jul 21, 2021 at 02:50, Ayoyimika Ajibade
<ayoyimikaajib...@gmail.com> wrote:
Hi there,
I have updated the node-qs from version 6.9.4 to
6.10.1+ds+_cs5.1.12 The package is available at
https://salsa.debian.org/Ayoyimika/node-qs/ and I am requesting for
sponsorship and I ensured all tests passed, it's lintian clean and
also built it in a clean chroot with sbuild.Thanks
Hi Ayoyimika,
Thanks for your work. Some comments about the package.
1. See
https://wiki.debian.org/Javascript/Nodejs/Npm2Deb#Update_copyright_file
about different versions of MIT and modify your copyright file
accordingly.
2. apt-file find get-intrinsic shows it is already embedded in
node-es-abstract and node-webassemblyjs so can try to install
get-intrinsic as a root_module in one of these packages and add a
dependency for it. So please use apt-file find before you embed a
package. I think providing it in node-es-abstract would be fine.
3. call-bind is also in the same situation as get-intrinsic
4. has-symbols is already available as a package, aptitude can be used
to find out if any real package provides a given virtual package.
aptitude show node-has-symbols
No candidate version found for node-has-symbols
Package: node-has-symbols
State: not a real package
Provided by: node-debbundle-es-to-primitive (1.2.1+~cs9.7.15-2)
5. aptitude show node-has
No candidate version found for node-has
Package: node-has
State: not a real package
Provided by: node-function-bind (1.1.1+repack-1)
6. Simplify the changelog entry by keeping only the latest version of
New Upstream version line and probably use a single entry for embedding
modules, use coma to separate all embedded modules in a single entry.
Please fix these issues and reply to this mail.
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
