Hi,

On 26.03.2014 08:26, Scott Kitterman wrote:
Before clamav had this new LogRotate option, the system handled it itself.
The more I'm looking at it, the more I think we should make LogRotate false
and set the file size option to 0 and not have clamav anything about rotating
the files.  Let lograte do it like it did before.  We've clearly added a bunch
more complexity to potentially expose to the user and I'm not sure what it
buys.

On platforms that don't have a good log rotation facility, this might make
sense, but the more I look at it, the less I think we need it.

Are you suggesting to set LogRotate to false by default, which still could be changed by dpkg-reconfigure clamav-base? I don't care either way, but this wouldn't help for anyone enabling this, who still had to run dpkg-reconfigure clamav-daemon and so on.

Or are you suggesting to completely remove the option for LogRotate?
But then, how should we handle the case, when a user sets it in clamd.conf? Just ignore it?

I think the easiest (and thus best?) way forward is to add a comment in README.Debian or the clamav-base/LogRotate template (or both) explaining that one has to run dpkg-reconfigure for the other packages to update the logrotation file.

Best regards,
Andreas


_______________________________________________
Pkg-clamav-devel mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-clamav-devel

Reply via email to