Quoting Jordan Justen (2019-01-07 11:50:43) > On 2018-12-18 14:57:43, Dylan Baker wrote: > > Quoting Eric Anholt (2018-12-18 11:21:08) > > > Jordan Justen <jordan.l.jus...@intel.com> writes: > > > > > > > On 2018-12-17 22:07:21, Tapani Pälli wrote: > > > >> Hi; > > > >> > > > >> On 12/17/18 11:50 AM, Jordan Justen wrote: > > > >> > Although I doubt it generates much traffic, I wanted to try to > > > >> > convert > > > >> > the https://piglit.freedesktop.org/ homepage into an 'auto-building' > > > >> > gitlab branch. > > > >> > > > > >> > I think the current site was built by ikiwiki, but I was after > > > >> > spending way more time that I hoped, I still was unable to reproduce > > > >> > the site without lots of extra undesirable links. > > > >> > > > > >> > So, I tried converting it to sphinx. Of course, I expected it would > > > >> > look somewhat different with sphinx. This change proved much easier, > > > >> > and I think looks pretty good: > > > >> > > > > >> > https://jljusten.pages.freedesktop.org/piglit/ > > > >> > > > >> Looks nice and clean! Maybe at same time the documentation could be > > > >> improved. Some of the Piglit options seem to be missing, as example I > > > >> never saw PIGLIT_PLATFORM documented, there is no list of platforms so > > > >> only way is to grep the source ... or are they somewhere? > > > > > > > > Eric pointed out that it could be good to make the website sources > > > > appear under the docs directory, like Mesa does. I made the changes to > > > > do that here: > > > > > > > > https://gitlab.freedesktop.org/jljusten/piglit/commits/master > > > > > > > > With this version, the website would be rebuilt whenever the docs > > > > directory changes on the master branch. > > > > > > > > I guess my point is that by putting the website under the docs > > > > directory of the main branch, maybe it will allow others to contribute > > > > changes (like this) more easily. :) > > > > > > > > Another change that we might consider is whether to use merge requests > > > > in piglit. That would also require a change to the website. > > > > > > This looks pretty nice to me. > > > > > > Acked-by: Eric Anholt <e...@anholt.net> > > > > I also think it looks pretty nice, and doesn't require me bothering Daniel > > Stone > > to remind me how to update the webpage when it needs to happen every 10 > > years or > > so... > > > > Acked-by: Dylan Baker <dy...@pnwbakers.com> > > Eric, Dylan, > > I didn't really follow the normal process of posting patches, yet I > think 2 Acked-by is better than average for code review on piglit. :) > > Should I post the patches to the list, or just merge it with your > guys' acks? > > -Jordan
Just push it with acks. Dylan
signature.asc
Description: signature
_______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
