On 12/28/2017 08:57 AM, Fabian Bieler wrote:
This series replaces hard-coded GLenum names with calls to piglit_get_gl_enum_name.
Nice. I guess I didn't realise how many tests needed this fix.
Notes: Some of the removed, hard-coded Glenum names had vendor, ARB, or EXT suffixes where piglit_get_gl_enum_name returns the suffix-less name. This means that some subtests are renamed by this series. In some cases string comparisons of command line arguments and GLenum names are replaced by integer comparison of piglit_get_gl_enum_from_name(cmd_line_arg) and GLenums. This is to ensure that future updates to gl.xml don't necessitate updates to all.py. However, these tests now abort on unknown command line arguments which were silently ignored, previously. I hope this is acceptable.
As long as we don't have aborts when running tests/all.py I think that's OK. Reviewed-by: Brian Paul <bri...@vmware.com> _______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
