I'm not familiar enough with the framework patches to give you a review there, hopefully someone else can chime in on those.

Patches 5, 7, 10 are:

Reviewed-by: Andres Rodriguez <andre...@gmail.com>

Other patches have replies inline.

Thanks for the patches,
Andres

On 2017-12-21 07:02 AM, Topi Pohjolainen wrote:
Here is a revision taking into account feedback from Andres and Fredrik.
Many thanks for both, I hope I didn't miss anything.

CC: Andres Rodriguez <andre...@gmail.com>
CC: Fredrik Hoeglund <fred...@kde.org>
CC: Jason Ekstrand <ja...@jlekstrand.net>

Topi Pohjolainen (11):
   framework: Check for vulkan availability
   framework: HACK: Read glslc path from env
   ext_memory_object: Add script for turning glsl into spirv c-array
   ext_memory_object: Support for setting up vulkan device
   ext_memory_object: Support for drawing with vulkan
   ext_memory_object: Support for setting up vulkan framebuffer
   ext_memory_object: Add tex layout command line
   ext_memory_object: Support for importing vulkan memory
   ext_memory_object: Support for creating simple vulkan pipelines
   ext_memory_object: Add helper for image type support
   ext_memory_object: Test render with vulkan and sample with gl

  CMakeLists.txt                                     |   3 +
  tests/spec/ext_memory_object/CMakeLists.gl.txt     |  18 +
  tests/spec/ext_memory_object/common.c              | 167 +++++
  tests/spec/ext_memory_object/common.h              |  51 ++
  .../compile_and_dump_glsl_as_spirv.py              | 139 +++++
  tests/spec/ext_memory_object/vk_common.c           | 670 +++++++++++++++++++++
  tests/spec/ext_memory_object/vk_common.h           | 176 ++++++
  .../ext_memory_object/vk_export_image_as_tex.c     | 219 +++++++
  tests/spec/ext_memory_object/vk_fb.c               | 346 +++++++++++
  tests/spec/ext_memory_object/vk_fragcoord.fs       |   7 +
  tests/spec/ext_memory_object/vk_fragcoord.vs       |   8 +
  11 files changed, 1804 insertions(+)
  create mode 100644 tests/spec/ext_memory_object/common.c
  create mode 100644 tests/spec/ext_memory_object/common.h
  create mode 100644 
tests/spec/ext_memory_object/compile_and_dump_glsl_as_spirv.py
  create mode 100644 tests/spec/ext_memory_object/vk_common.c
  create mode 100644 tests/spec/ext_memory_object/vk_common.h
  create mode 100644 tests/spec/ext_memory_object/vk_export_image_as_tex.c
  create mode 100644 tests/spec/ext_memory_object/vk_fb.c
  create mode 100644 tests/spec/ext_memory_object/vk_fragcoord.fs
  create mode 100644 tests/spec/ext_memory_object/vk_fragcoord.vs

_______________________________________________
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to