On Mon, 2017-06-19 at 16:22 -0700, Eric Anholt wrote: > Marek Olšák <mar...@gmail.com> writes: > > > From: Marek Olšák <marek.ol...@amd.com> > > > > Most of the original code is simply wrong. > > > > This patch makes sure that at least the returned GPU offsets and strides > > are correct. This doesn't fix the incorrect CPU upload path for non-zero > > planes. GBM doesn't seem to have the capability to map a specific plane > > for CPU access. > > Reviewed-by: Eric Anholt <e...@anholt.net>
This patch breaks build using older mesa/gbm: $ rpm -q mesa-libgbm-devel mesa-libgbm-devel-17.0.5-3.fc25.x86_64 /usr/bin/cc -I/home/vesely/mesa/include -Wall -std=gnu99 -Werror=vla -Werror=pointer-arith -Werror=variadic-macros -g -rdynamic CMakeFiles/point-sprite.dir/point-sprite.c.o -o ../../../../bin/point- sprite -Wl,-rpath,/home/vesely/piglit/lib:: ../../../../lib/libpiglitutil_gl.so.0 -lGL ../../../../lib/libpiglitutil.so.0 -lrt -ldl -lxkbcommon -lpng -lz -lm -lEGL -lgbm -lwaffle-1 -ldrm -lxcb -lxcb-dri2 -ldrm_intel -ldrm -lxcb -lxcb-dri2 -ldrm_intel -lX11 -lwayland-egl -lwayland-client -lGL ../../../../lib/libpiglitutil_gl.so.0: undefined reference to `gbm_bo_get_offset' ../../../../lib/libpiglitutil_gl.so.0: undefined reference to `gbm_bo_get_stride_for_plane' collect2: error: ld returned 1 exit status looks like the used functions were added in 17.1, so this needs to bump gbm requirement (or check for those functions explicitly). Jan > _______________________________________________ > Piglit mailing list > Piglit@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/piglit
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
