I have just sent a equivalent series to mesa, where I already explained in detail the rationale behind this change [1], but in summary, ARB_internalformat_query2 should also work on gles and right now is only tested on desktop gl.
Patches 1-6 of this series fix the tests in order to properly take into account OpenGL ES 2.0/3.x. Patches 7-9 add the infrastructure to configure them properly, and add the -gle2, -gles3 counterpart tests. Patch 10 tweaks the local copy of the khronos registry xml. This is needed because that xml doesn't list the extension as available for OpenGL ES. As this xml is used to generate the dispatch code, without this change the gles2 and gles3 tests will fail when trying to call glGetInternalformati64v. This is clearly (imho) a bug on the xml file. I already opened a public bug about it [2]. Patches 11-12 are just nice-to-have. More details/better formating when printing some failing cases, that I implemented while working on this. [1] https://lists.freedesktop.org/archives/mesa-dev/2016-May/116673.html [2] https://www.khronos.org/bugzilla/show_bug.cgi?id=1496 Alejandro Piñeiro (12): arb_internalformat_query2: fix framebuffer object dependency check arb_internalformat_query2: add gles3 checks when checking for dependencies arb_internalformat_query2: being more strict with the format/type inferred from internalformat arb_internalformat_query2: GetTexLevelParameter requires desktop gl or gles 3.1 arb_internalformat_query2: color-renderable formats are different for gles arb_internalformat_query2: 0 is a valid value for NUM_SAMPLE_COUNTS arb_internalformat_query2: add common config macro for all query2 tests arb_internalformat_query2: add gles2 tests arb_internalformat_query2: add gles3 tests registry: arb_internalformat_query2 should be also supported on gles2 arb_internalformat_query2: print more details when filter test fails arb_internalformat_query2: print properly the value of a failing case registry/gl.xml | 2 +- tests/all.py | 34 +++ .../arb_internalformat_query2/CMakeLists.gles2.txt | 17 ++ .../arb_internalformat_query2/CMakeLists.gles3.txt | 17 ++ tests/spec/arb_internalformat_query2/api-errors.c | 8 +- .../arb_internalformat_query2/color-encoding.c | 7 +- tests/spec/arb_internalformat_query2/common.c | 281 +++++++++++++++++++-- tests/spec/arb_internalformat_query2/common.h | 36 +++ tests/spec/arb_internalformat_query2/filter.c | 22 +- .../arb_internalformat_query2/format-components.c | 7 +- .../generic-pname-checks.c | 7 +- .../image-format-compatibility-type.c | 7 +- .../spec/arb_internalformat_query2/image-texture.c | 7 +- .../internalformat-size-checks.c | 7 +- .../internalformat-type-checks.c | 7 +- .../arb_internalformat_query2/max-dimensions.c | 7 +- tests/spec/arb_internalformat_query2/minmax.c | 59 ++--- .../arb_internalformat_query2/samples-pnames.c | 8 +- .../texture-compressed-block.c | 7 +- 19 files changed, 413 insertions(+), 134 deletions(-) create mode 100644 tests/spec/arb_internalformat_query2/CMakeLists.gles2.txt create mode 100644 tests/spec/arb_internalformat_query2/CMakeLists.gles3.txt -- 2.7.4 _______________________________________________ Piglit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/piglit
