On Thu, 2016-04-14 at 11:20 -0700, Dylan Baker wrote: ... > diff --git a/generated_tests/gen_conversion_fp64.py > > b/generated_tests/gen_conversion_fp64.py > > new file mode 100644 > > index 0000000..5fe0bf2 > > --- /dev/null > > +++ b/generated_tests/gen_conversion_fp64.py > > @@ -0,0 +1,604 @@ > > ... > > +from __future__ import print_function, division, absolute_import > > +import abc > > +import argparse > > +import os > > +import itertools > > +import struct > small nit, could you put a newline between numpy ans struct, and then > sort the above imports? > > > > > +import numpy as np
I will :) ... > > - _dmat4x3 = _mat4x3; > > -} > > -- > > 2.8.0.rc3 > > > > I didn't look over this too closely, but other than the one tiny nit > it looked okay. > > For the python and mako: > Acked-by: Dylan Baker <[email protected]> Thanks! -- Br, Andres
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Piglit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/piglit
