On Sat, Apr 25, 2015 at 4:39 AM, Timothy Arceri <[email protected]> wrote: > On Sat, 2015-04-25 at 02:02 -0700, Matt Turner wrote: >> On Tue, Mar 31, 2015 at 10:01 PM, Timothy Arceri <[email protected]> >> wrote: >> > Although the existing tests are valid until link time, >> > it doesn't make much sense to test this way. >> > --- >> > .../compiler/input-array-array-var.frag | 15 >> > +++++++++++++++ >> > .../compiler/input-array-array-var.vert | 15 >> > --------------- >> > .../compiler/input-array-var-array.frag | 15 >> > +++++++++++++++ >> > .../compiler/input-array-var-array.vert | 15 >> > --------------- >> > .../compiler/input-var-array-array.frag | 15 >> > +++++++++++++++ >> > .../compiler/input-var-array-array.vert | 15 >> > --------------- >> > 6 files changed, 45 insertions(+), 45 deletions(-) >> > create mode 100644 >> > tests/spec/arb_arrays_of_arrays/compiler/input-array-array-var.frag >> > delete mode 100644 >> > tests/spec/arb_arrays_of_arrays/compiler/input-array-array-var.vert >> > create mode 100644 >> > tests/spec/arb_arrays_of_arrays/compiler/input-array-var-array.frag >> > delete mode 100644 >> > tests/spec/arb_arrays_of_arrays/compiler/input-array-var-array.vert >> > create mode 100644 >> > tests/spec/arb_arrays_of_arrays/compiler/input-var-array-array.frag >> > delete mode 100644 >> > tests/spec/arb_arrays_of_arrays/compiler/input-var-array-array.vert >> >> I'm not sure I understand the rationale. Could you explain? > > Sure. These are compile tests to see if the implementation allows a > shader input to be an array of arrays, however a vertex can't have input > varyings (a mistake from copy and pasting when I created the tests). > > According to the spec having an input in a vertex shader is only a link > time error so technically these tests are still valid as vertex shaders > because we are just checking compile time validation but it makes sense > to just fix this and change them to fragment shaders instead.
Ahh, that makes sense. > I can add something like above to the commit message before committing > if you like. Sure, that'd be great. Thanks Timothy. Reviewed-by: Matt Turner <[email protected]> _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
