On Tue, Mar 10, 2015 at 10:57:50AM -0700, Vinson Lee wrote: > On Tue, Mar 10, 2015 at 10:51 AM, Dylan Baker <[email protected]> wrote: > > a couple of minor nits below, with those addressed: > > Reviewed-by: Dylan Baker <[email protected]> > > > > On Mon, Mar 09, 2015 at 11:02:17PM -0700, Vinson Lee wrote: > >> Signed-off-by: Vinson Lee <[email protected]> > >> --- > >> tests/oglconform.py | 23 ++++++++++++++--------- > >> 1 file changed, 14 insertions(+), 9 deletions(-) > >> > >> diff --git a/tests/oglconform.py b/tests/oglconform.py > >> index 436247c..919477f 100644 > >> --- a/tests/oglconform.py > >> +++ b/tests/oglconform.py > >> @@ -39,14 +39,17 @@ if not os.path.exists(bin_oglconform): > >> > >> profile = TestProfile() > >> > >> -############################################################################# > >> -##### OGLCTest: Execute a sub-test of the Intel oglconform test suite. > >> -##### > >> -##### To use this, create an 'oglconform' symlink in piglit/bin. Piglit > >> -##### will obtain a list of tests from oglconform and add them all. > >> -############################################################################# > >> + > >> class OGLCTest(Test): > >> - skip_re = re.compile(r'Total Not run: 1|no test in schedule is > >> compat|GLSL [13].[345]0 is not supported|wont be scheduled due to lack of > >> compatible fbconfig') > >> + """ > > > > Pull the first line onto the same line as the """ > > > >> + OGLCTest: Execute a sub-test of the Intel oglconform test suite. > >> + > >> + To use this, create an 'oglconform' symlink in piglit/bin. Piglit > >> + will obtain a list of tests from oglconform and add them all. > > > > Add a newline here > > > >> + """ > >> + skip_re = re.compile(r'Total Not run: 1|no test in schedule is ' > >> + r'compat|GLSL [13].[345]0 is not supported|wont > >> be ' > >> + r'scheduled due to lack of compatible fbconfig') > >> > >> def __init__(self, category, subtest): > >> super(OGLCTest, self).__init__([bin_oglconform, '-minFmt', '-v', > >> '4', > >> @@ -65,13 +68,15 @@ class OGLCTest(Test): > >> testlist_file = '/tmp/oglc.tests' > >> > >> with open(os.devnull, "w") as devnull: > >> - subprocess.call([bin_oglconform, '-generateTestList', testlist_file], > >> stdout=devnull.fileno(), stderr=devnull.fileno()) > >> + subprocess.call([bin_oglconform, '-generateTestList', testlist_file], > >> + stdout=devnull.fileno(), stderr=devnull.fileno()) > >> > >> with open(testlist_file) as f: > >> testlist = f.read().splitlines() > >> for l in testlist: > >> try: > >> category, test = l.split() > >> - profile.test_list[grouptools.join('oglconform', category, > >> test)] = OGLCTest(category, test) > >> + profile.test_list[grouptools.join('oglconform', category, > >> test)] =\ > > > > please add a space between the = and \ > > > > This will violate the 79 character maximum line length.
Okay. > > >> + OGLCTest(category, test) > >> except: > >> continue > >> -- > >> 2.3.2 > >> > >> _______________________________________________ > >> Piglit mailing list > >> [email protected] > >> http://lists.freedesktop.org/mailman/listinfo/piglit
signature.asc
Description: Digital signature
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
