On 21 February 2015 at 08:56, Ilia Mirkin <imir...@alum.mit.edu> wrote:
> On Fri, Feb 20, 2015 at 5:55 PM, Dave Airlie <airl...@gmail.com> wrote:
>> On 20 February 2015 at 20:13, Ilia Mirkin <imir...@alum.mit.edu> wrote:
>>> Signed-off-by: Ilia Mirkin <imir...@alum.mit.edu>
>>
>> Looks good to me, did you mean to reindent or respace the types stuff?
>> makes it harder to see what this patch adds.
>
> Yeah, originally I added an extra field so I was going to have to do
> it anyways. But DOUBLE is longer than FLOAT, so it looks awkward if I
> don't do it. I can undo if it bugs you...
>

Nah just makes review a bit harder, clean code is nicer here.

I was actually looking to see if you had added something :-)

Dave.
_______________________________________________
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to