This commit did not fix the issue. This commit will only attempt to define the variable if it's already defined. The more correct fix is to use "#ifndef" instead of "#ifdef" it's specific.
So to be exact, this line: #ifdef EGL_OPENGL_ES3_BIT_KHR should be either: #ifndef EGL_OPENGL_ES3_BIT_KHR or: ( This is only required on extremely outdated compilers... most support #ifndef) #if !defined(EGL_OPENGL_ES3_BIT_KHR) On Tue, Nov 27, 2012 at 8:07 PM, Chad Versace <[email protected]> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 11/26/2012 04:52 PM, Ken Phillis Jr wrote: >> This patch is looking good, and the only change I'd suggest is using >> "#ifndef EGL_OPENGL_ES3_BIT_KHR" and "#endif" around the define for >> EGL_OPENGL_ES3_BIT_KHR since some compilers might fail due to a possible >> redefine. > > Ken, I guarded the #define with an #ifdef, as you suggested, then > committed the patch. > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.12 (GNU/Linux) > Comment: Using GnuPG with undefined - http://www.enigmail.net/ > > iQIcBAEBAgAGBQJQtXHIAAoJEAIvNt057x8iTYcQAIS+Rcf7WDMIFmy9ldS6U/EH > fs62ZcY/bRYeRWWCZXOnjWuKzwZ81rYWFBf/u5MHsm9VTT+F6YoyFO/YGxZ/bKwD > XLzL6ZpYjxjv9o+mqWrAkZiQBBjm0UNhFsJc4/7H5Zw5F+mdME1mhwsn0g5nZ0fo > ojBEiKn2e+NXkHJhXHcjRgrcES7JJj8NVjaiqzg+oMDmDt7gpVBvilWugiclKYKx > +qKMY8JA7MEetaEDpfRTv9rnGGt//w9t/HUZ3FQxV5rOfxS2OjPDdL6KuyuKo2Xm > jrpeztlq7F/GaYRQvMbm1COrlgw0RS59za+5FbHh6g2CFRyyEgFF08jWe4UaiM82 > 95qDb59cirCtNnjTb3Smvw1d8a0YxFPBYG6cRUP4Ip/GWA7PF1f+W3v+ty7QgKhm > os8BdLxz9wAWwhpx/MqRuCKPksRVTiiFRPJ97wBVBbSWUesXiiY+tHjpbjXXC0oQ > LFWnFSEkXxAeHHHuwx0/266IBq9SBmHlN0F8wqkjbnex3/sg/0GxcddwszvA1oSb > 2J4z6UdwKBRPfGIs0wW0DsKU6b8mkmrgm1gAvZQTLKvW4bSSQxOIZkyEG0+AVAJg > ncqRYk08N/nPcV8jUC+UfqO/pU1vxyNloDF+345cSBPhcPrp1OKA5BC6SF162a2O > EeOfS6aube4uf2YITH5Y > =Dsbp > -----END PGP SIGNATURE----- _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
