Could some one please have a look thru my code and tell me why it creates a new record 
instead of updating the record?

What this script is suposed to do is show a HTML form .. then once the user fills it 
out it then shows another form which echo's the values inputted in the first so the 
user can update if they made a mistake .. it does everything right .. up until the 
user clicks on update ... where instead of updating the record it creates a new one ..

Any sussestions/Help would be greatful


Peter Houchin
Sun Rentals
[EMAIL PROTECTED]

<?
$db = mysql_connect("localhost","root","password");
 mysql_select_db("rentdb",$db);

if ($submit){
 
 $result = mysql_query("INSERT INTO app 
(name,company,address,suburb,state,post,areacode,phone,faxareacode,fax,email,secret) 
VALUES 
('$name','$company','$address','$suburb','$state','$post','$areacode','$phone','$faxareacode','$fax','$email','$secret')");

 
 if($name){
 $result="SELECT * FROM app WHERE name=$name";
 if ($submit){

 $result ="UPDATE app SET 
name='$name',company='$company',address='$address',suburb='$suburb',state='$state',post='$post',areacode='$areacode',phone='$phone',faxareacode='$faxareacode',fax='$fax',email='$email',secret='$secret'
 WHERE name=$name";
echo mysql_error();

}


echo "<p><p>";
echo "<TABLE BORDER=0 WIDTH=800 >";
echo "<tr><td>";
 
?> <table border="0" width="650" align="center"> <tr> <td> <font face="Helvetica, 
sans-serif" size="3" color="#00499C"> 
Please Check your information, and change any details that are not correct, then 
click update.<br> if this information is correct <? echo "<a 
href=thankyou.php?session=$session>click here</a>";?>.</font><p> 
</td></tr> </table><form name=check method="POST" action=""></font> <TABLE BORDER=0 
CELLPADDING=3 CELLSPACING=1 WIDTH=500 BGCOLOR=#990033 ALIGN=CENTER> 
<tr BGCOLOR=#CCCCCC> <td colspan=2 bgcolor=#006699><div align=center> <font 
face=Helvetica, sans-serif size=3 color=#FFFFFF><b>The 
information you entered is:</b></font> </div></td></tr> <tr BGCOLOR=#CCCCCC> <td 
bgcolor=#006699 width=122> 
<input type=hidden name=id value="<? echo $id ?>"> <font face=Helvetica, sans-serif 
size=3 color=#FFFFFF><b>Your 
Name:</b></font></td><td><div align=center><font face=Helvetica, sans-serif size=3 
color=#000000><input type=text name=name value="<?echo 
$name?>"></font></div></td></tr> 
<tr BGCOLOR=#CCCCCC> <td bgcolor=#006699 width=122> <font face=Helvetica, sans-serif 
size=3 color=#FFFFF width=180><b><FONT 
COLOR="#FFFFFF">Company:</FONT></b></font></td><td><div align=center><font 
face=Helvetica, sans-serif size=3 color=#000000><input type=text name=company 
value="<?echo $company?>"></font></div></td></tr> 
<tr BGCOLOR=#CCCCCC> <td bgcolor=#006699 width=122> <font face=Helvetica, sans-serif 
size=3 color=#FFFFFF width=180><b>Address:</b></font></td><td><div align=center><font 
face=Helvetica, sans-serif size=3 color=#000000><input type=text name=address 
value="<?echo $address?>"></font></div></td></tr> 
<tr BGCOLOR=#CCCCCC> <td bgcolor=#006699 width=122> <font face=Helvetica, sans-serif 
size=3 color=#FFFFFF width=180><b>Suburb:</b></font></td><td><div align=center><font 
face=Helvetica, sans-serif size=3 color=#000000><input type=text name=suburb 
value="<?echo $suburb?>"></font></div></td></tr> 
<tr BGCOLOR=#CCCCCC> <td bgcolor=#006699 width=122> <font face=Helvetica, sans-serif 
size=3 color=#FFFFFF width=180><b>State:</b></font></td><td><div align=center><font 
face=Helvetica, sans-serif size=3 color=#000000><input type=text name=state 
value="<?echo $state?>"></font></div></td></tr> 
<tr BGCOLOR=#CCCCCC> <td bgcolor=#006699 width=122> <font face=Helvetica, sans-serif 
size=3 color=#FFFFFF width=180><b>Post 
Code:</b></font></td><td><div align=center><font face=Helvetica, sans-serif size=3 
color=#000000><input type=text name=post value="<?echo 
$post?>"></font></div></td></tr> 
<tr BGCOLOR=#CCCCCC> <td bgcolor=#006699 width=122> <font face=Helvetica, sans-serif 
size=3 color=#FFFFFF width=180><b>Phone:*</b></font></td><td><div align=center><font 
face=Helvetica, sans-serif size=3 color=#000000><SELECT NAME="areacode"><OPTION 
VALUE="02" <? if ($areacode == '02') { echo 'SELECTED '; }?>>02</OPTION><OPTION 
VALUE="03" <? if ($areacode == '03') { echo 'SELECTED '; }?>>03</OPTION><OPTION 
VALUE="07" <? if ($areacode == '07') { echo 'SELECTED '; }?>>07</OPTION><OPTION 
VALUE="08" <? if ($areacode == '08') { echo 'SELECTED '; 
}?>>08</OPTION></SELECT><input type=text name=phone value="<?echo 
$phone?>"></font></div></td></tr> 
<tr BGCOLOR=#CCCCCC> <td bgcolor=#006699 width=122> <font face=Helvetica, sans-serif 
size=3 color=#FFFFFF width=180><b>Fax:*</b></font></td><td><div align=center><font 
face=Helvetica, sans-serif size=3 color=#000000><SELECT NAME="faxareacode"><OPTION 
VALUE="02" <? if ($faxareacode == '02') { echo 'SELECTED '; }?>>02</OPTION><OPTION 
VALUE="03" <? if ($faxareacode == '03') { echo 'SELECTED '; }?>>03</OPTION><OPTION 
VALUE="07" <? if ($faxareacode == '07') { echo 'SELECTED '; }?>>07</OPTION><OPTION 
VALUE="08" <? if ($faxareacode == '08') { echo 'SELECTED '; 
}?>>08</OPTION></SELECT><input type=text name=fax value="<?echo 
$fax?>"></font></div></td></tr> 
<tr BGCOLOR=#CCCCCC> <td bgcolor=#006699 width=122> <font face=Helvetica, sans-serif 
size=3 color=#FFFFFF width=180><b>Email 
Address:</b></font></td><td><div align=center><font face=Helvetica, sans-serif size=3 
color=#000000><input type=text name=email value="<?echo 
$email?>"></font></div></td></tr> 
<tr><td bgcolor=#006699><div align=center><FONT FACE="Helvetica" SIZE="3" 
COLOR="#FFFFFF"><B>Secret 
Word:**</B></FONT></div></td><td bgcolor=#CCCCCC><DIV ALIGN="CENTER"><INPUT 
TYPE="text" NAME="secret" VALUE="<? echo $secret?>" MAXLENGTH="15"></DIV></td></tr>
<tr>
<td colspan=2 bgcolor=#CCCCCC>
<DIV ALIGN="CENTER">
<INPUT TYPE="submit" NAME="submit" VALUE="update">
</DIV>
</td>
</tr>
</table>
</form>
<?
echo "</td></tr></table>\n";
}
} 
else {
 
 
 
?> </P><table width="800" border="0" align="center"> <tr> <td height="485"> <form 
method="post" action="" name="app"> 
<div align="center"> <table width="700" border="0" align="center"> <tr> <td 
width="112" height="2"><font face="Helvetica, sans-serif" size="3" 
color="#00499C">Name:</font></td><td width="578" height="2"> 
<input type="text" name="name"> </td></tr> <tr> <td width="112" height="2"><font 
face="Helvetica, sans-serif" size="3" color="#00499C">Company:</font></td><td 
width="578" height="2"> 
<input type="text" name="company"> </td></tr> <tr> <td width="112" height="2"><font 
face="Helvetica, sans-serif" size="3" color="#00499C">Address:</font></td><td 
width="578" height="2"> 
<input type="text" name="address" size="35"></td></tr> <tr><td WIDTH="112"><font 
face="Helvetica, sans-serif" size="3" color="#00499C"> 
Suburb: </font></td><td WIDTH="578"><input type="text" name="suburb"> </td></tr> 
<tr><td WIDTH="112"><font face="Helvetica, sans-serif" size="3" color="#00499C"> 
State: </font></td><td WIDTH="578"> <select name="state" size="1"> <option 
value="Canberra">ACT</option> 
<option value="New South Wales">NSW</option> <option value="Northern 
Territory">NT</option> 
<option value="Queensland">QLD</option> <option value="South Australia">SA</option> 
<option value="Tasmania">TAS</option> <option value="Victoria">VIC</option> <option 
value="Western Australia">WA</option> 
</select> <font face="Helvetica, sans-serif" size="3" color="#00499C"> Post 
Code:</font> 
<input type="text" name="post" size="4"> </td></tr> <tr><td width="112" 
height="2"><font face="Helvetica, sans-serif" size="3" 
color="#00499C">Phone:*</font></td><td width="578" height="2"> 
<SELECT NAME="areacode"> <OPTION VALUE="02">02</OPTION> <OPTION VALUE="03">03</OPTION> 

<OPTION VALUE="07">07</OPTION> <OPTION VALUE="08">08</OPTION> </SELECT> <input 
type="text" name="phone" size="10" maxlength="9"> 
</td></tr> <tr> <td width="112" height="2"><font face="Helvetica, sans-serif" size="3" 
color="#00499C">Fax:*</font></td><td width="578" height="2"> 
<SELECT NAME="faxareacode"> <OPTION VALUE="02">02</OPTION> <OPTION 
VALUE="03">03</OPTION> 
<OPTION VALUE="07">07</OPTION> <OPTION VALUE="08">08</OPTION> </SELECT> <input 
type="text" name="fax"> 
</td></tr><tr><td width="112" height="2"><FONT FACE="Helvetica, sans-serif" SIZE="3" 
COLOR="#00499C">Email:</FONT></td><td width="578" height="2"><INPUT TYPE="text" 
NAME="email"></td></tr> 
<tr> <td width="112" height="2"><FONT FACE="Helvetica, sans-serif" SIZE="3" 
COLOR="#003399">Secret 
word:**</FONT></td><td width="578" height="2"><INPUT TYPE="text" NAME="secret" 
MAXLENGTH="15"> 
</td></tr> <tr> <td width="112" height="2">&nbsp;</td><td width="578" height="2"> 
<input type="submit" name="submit" value="Submit"> 
<input type="reset" name="submit2" value="Clear"> <p> <font face="Helvetica, 
sans-serif" size="3" color="#00499C"><b>* 
Please Include your area code with your phone &amp; fax number.</b></font> <BR><FONT 
FACE="Helvetica, sans-serif" SIZE="3" COLOR="#00499C"><B>**Please 
include a secret word (maximum of 15 characters) for verification should you lose 
your password.</B></FONT></td></tr> </table></div></form><?
}
echo mysql_error();
?>

Reply via email to