Woops :)

At 18:01 16/2/2001, Ben Mansell wrote:
>joosters                Fri Feb 16 08:01:35 2001 EDT
>
>   Modified files:
>     /php4/sapi/isapi    php4isapi.c
>   Log:
>   Fixed non-threadsafe code: 'isapi_special_server_variables' was a static
>   buffer, and not allocated per-connection. Bad bad bad!
>
>
>Index: php4/sapi/isapi/php4isapi.c
>diff -u php4/sapi/isapi/php4isapi.c:1.65 php4/sapi/isapi/php4isapi.c:1.66
>--- php4/sapi/isapi/php4isapi.c:1.65    Tue Jan 16 02:44:52 2001
>+++ php4/sapi/isapi/php4isapi.c Fri Feb 16 08:01:34 2001
>@@ -74,8 +74,6 @@
>  #define SPECIAL_VAR_HTTPS              1
>  #define SPECIAL_VAR_PHP_SELF   2
>
>-static char *isapi_special_server_variables[NUM_SPECIAL_VARS];
>-
>  static char *isapi_server_variable_names[] = {
>         "AUTH_PASSWORD",
>         "AUTH_TYPE",
>@@ -426,6 +424,7 @@
>         DWORD variable_len = ISAPI_SERVER_VAR_BUF_SIZE;
>         char *variable;
>         char *strtok_buf = NULL;
>+       char *isapi_special_server_variables[NUM_SPECIAL_VARS];
>         LPEXTENSION_CONTROL_BLOCK lpECB;
>
>         lpECB = (LPEXTENSION_CONTROL_BLOCK) SG(server_context);
>
>
>
>--
>PHP CVS Mailing List (http://www.php.net/)
>To unsubscribe, e-mail: [EMAIL PROTECTED]
>For additional commands, e-mail: [EMAIL PROTECTED]
>To contact the list administrators, e-mail: [EMAIL PROTECTED]

--
Zeev Suraski <[EMAIL PROTECTED]>
CTO &  co-founder, Zend Technologies Ltd. http://www.zend.com/


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Reply via email to