Edit report at http://bugs.php.net/bug.php?id=48711&edit=1
ID: 48711
Comment by: jthijssen at noxlogic dot nl
Reported by: brettz9 at yahoo dot com
Summary: metaphone() and sch, ch, gh
Status: Feedback
Type: Bug
Package: Strings related
Operating System: Windows
PHP Version: 5.3
Assigned To: pajoye
Block user comment: N
Private report: N
New Comment:
Pierre, I've added a phpt testcase inside the patch (bug48711.phpt). Or
do you mean a phpt for the extra metaphone parameter (probably a
metaphone_variation.phpt)?
Previous Comments:
------------------------------------------------------------------------
[2011-02-26 20:18:33] paj...@php.net
hi,
Thanks for the patch!
Can you add a test case for it please?
------------------------------------------------------------------------
[2011-02-26 19:54:08] jthijssen at noxlogic dot nl
I've added a patch with the 4 items as described by brettz9.
The first one introduces a "traditional" boolean flag in metaphone as a
third optional parameter. I'm not 100% sure why this parameter is here.
Either we should always convert CHR/SCH to X or to K. It makes the
function much more complicated this way for end-users.
------------------------------------------------------------------------
[2009-08-03 01:00:02] php-bugs at lists dot php dot net
No feedback was provided for this bug for over a week, so it is
being suspended automatically. If you are able to provide the
information that was originally requested, please do so and change
the status of the bug back to "Open".
------------------------------------------------------------------------
[2009-07-26 19:36:59] j...@php.net
Please provide patches against all current branches, I don't think this
is just an issue with HEAD?
------------------------------------------------------------------------
[2009-06-29 04:06:33] brettz9 at yahoo dot com
My apologies, I was off by one line number in item #4; it should instead
say:
inside the first 'if' of the 2nd 'G' case (insert right after line 342):
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
http://bugs.php.net/bug.php?id=48711
--
Edit this bug report at http://bugs.php.net/bug.php?id=48711&edit=1
