Edit report at http://bugs.php.net/bug.php?id=51799&edit=1
ID: 51799
Updated by: f...@php.net
Reported by: admin at saltwaterc dot net
Summary: FPM crashes if the include is enabled, but there are
no files
-Status: Assigned
+Status: Closed
Type: Bug
Package: FPM related
Operating System: Linux
PHP Version: 5.3.2
Assigned To: fat
New Comment:
This bug has been corrected in revision 299302.
When glob() returns GLOB_NOMATCH, the log message has been changed from
ERROR to
WARNING and FPM continues to parse the conf file without stopping.
Previous Comments:
------------------------------------------------------------------------
[2010-05-12 20:29:11] f...@php.net
Automatic comment from SVN on behalf of fat
Revision: http://svn.php.net/viewvc/?view=revision&revision=299302
Log: Fix #51799, when glob returns nothing, it was handle as an error
instead of a warning.
------------------------------------------------------------------------
[2010-05-12 15:57:31] admin at saltwaterc dot net
Description:
------------
If the include configuration option is enabled, but the pool directory
is empty, php-fpm crashes pretty ugly.
I could manage to enable the service by creating an empty default.conf
file within the fpm.d directory, but obviously this isn't the solution.
The used FPM is the latest trunk indicated by php-fpm.org
http://svn.php.net/repository/php/php-src/trunk/sapi/fpm.
Test script:
---------------
The include line is:
include=/usr/local/zend/etc/fpm.d/*.conf
r...@test-lucid:/usr/local/zend/etc/fpm.d# ls -la
total 8
drwxr-sr-x 2 root zend 4096 May 12 11:59 .
drwxrwsr-x 7 root zend 4096 May 12 11:59 ..
r...@test-lucid:/usr/local/zend/etc/fpm.d#
Expected result:
----------------
To be able to start the php-fpm service just with the default pool from
php-fpm.conf if fpm.d is empty. In my humble opinion the application
shouldn't crash if no pattern is matched.
Actual result:
--------------
May 12 12:10:52.239695 [ERROR] Nothing match the include pattern
'/usr/local/zend/etc/fpm.d/*.conf' from /usr/local/zend/etc/php-fpm.conf
at line 10.
The backtrace is quite useless since the error is generated by
sapi/fpm/fpm/fpm_conf.c, after the glob() call.
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/bug.php?id=51799&edit=1
