Ah I did not know that we have action bar and button bar. I should ask esteban
S. > On 10 Sep 2020, at 23:41, Sebastian Jordan <sebastian...@hotmail.com> wrote: > > could you use a menuButtonbar for the buttons? Like that we can style it > later. > Ok, I changed the ActionBar for a ButtonBar. Also I added a refresh items > button, in case you saved a new rule you can see it without closing the > current window. All is on the master branch. > Now what would be great is to see if we can use the same logic than the > playground so that the tool keeps a list of previous expression. > I will start to work on this in a time. > > Thanks, > Sebastian > De: Pharo-users <pharo-users-boun...@lists.pharo.org > <mailto:pharo-users-boun...@lists.pharo.org>> en nombre de Stéphane Ducasse > <stephane.duca...@inria.fr <mailto:stephane.duca...@inria.fr>> > Enviado: jueves, 10 de septiembre de 2020 15:35 > Para: Any question about pharo is welcome <pharo-users@lists.pharo.org> > Asunto: Re: [Pharo-users] Rewrite Tool set in Spec2 changes > > > >> On 9 Sep 2020, at 19:28, Sebastian Jordan <sebastian...@hotmail.com >> <mailto:sebastian...@hotmail.com>> wrote: >> >> Hi to all, >> >> Thanks to the received feedback, I made some changes on RewriteTool-Spec2. >> First, when loading a rule a more detailed description of the rules is >> displayed on the RewriteRulesLoaderPresenter. > Yes this is much better. > - could you use a menuButtonbar for the buttons? Like that we can style it > later. >> Also, I added several examples of Rewrite Rules. These rules are examples of >> common refactors that are made in Pharo. > Yes this is good. >> Finally, when you open Match Tool from the Basic Rewrite Editor, the >> searchFor part of the rule is set to MatchTool pattern code. > Yes you see having a default value is much better. > > Now what would be great is to see if we can use the same logic than the > playground > so that the tool keeps a list of previous expression. > > S > >> Screenshot of the new way to load a rule: https://imgur.com/gallery/Rp6Jfw2 >> <https://imgur.com/gallery/Rp6Jfw2> >> The repo of the tool: https://github.com/jordanmontt/RewriteTool-Spec2 >> <https://github.com/jordanmontt/RewriteTool-Spec2> >> >> Thanks! >> Sebastian >> >> <https://imgur.com/gallery/Rp6Jfw2> >> Rewrite Rule Loader <https://imgur.com/gallery/Rp6Jfw2> >> Imgur: The magic of the Internet >> imgur.com <http://imgur.com/> > -------------------------------------------- > Stéphane Ducasse > http://stephane.ducasse.free.fr <http://stephane.ducasse.free.fr/> / > http://www.pharo.org <http://www.pharo.org/> > 03 59 35 87 52 > Assistant: Aurore Dalle > FAX 03 59 57 78 50 > TEL 03 59 35 86 16 > S. Ducasse - Inria > 40, avenue Halley, > Parc Scientifique de la Haute Borne, Bât.A, Park Plaza > Villeneuve d'Ascq 59650 > France -------------------------------------------- Stéphane Ducasse http://stephane.ducasse.free.fr / http://www.pharo.org 03 59 35 87 52 Assistant: Aurore Dalle FAX 03 59 57 78 50 TEL 03 59 35 86 16 S. Ducasse - Inria 40, avenue Halley, Parc Scientifique de la Haute Borne, Bât.A, Park Plaza Villeneuve d'Ascq 59650 France
