I added a comment and some code to

https://github.com/DuneSt/ChartJs/issues/1

> On 12 Feb 2020, at 10:54, Sven Van Caekenberghe <s...@stfx.eu> wrote:
> 
> Hi Guillaume,
> 
> Thank you for your reply.
> 
> I see that the version supported/implemented in DuneSt/ChartJs is 1.0.2 (from 
> 2015) while the current Chart.js version is 2.0, so it would probably be time 
> for an upgrade.
> 
> I also don't know the perfect answer to the Seaside dependency, I'll write 
> some more in another reply.
> 
> I tried making a sub class of ChartBar called ChartHorizontalBar overwriting 
> only 
> 
> forChartJS
>       ^ 'HorizontalBar'  
> 
> and then using that as an argument to #chartType: but alas that did not work.
> 
> I must admit that I do not really understand how I have to mentally map the 
> official JavaScript documentation to the model in Pharo and how it is 
> implemented (#forChartJS does not seem to be used as argument/value but as a 
> function call).
> 
> Sven
> 
>> On 11 Feb 2020, at 20:12, Guillaume Larcheveque 
>> <guillaume.larcheve...@gmail.com> wrote:
>> 
>> 
>> 
>> Le mar. 11 févr. 2020 à 17:07, Sven Van Caekenberghe <s...@stfx.eu> a écrit :
>> Hi,
>> 
>> I am trying to use DuneSt / ChartJs [ https://github.com/DuneSt/ChartJs ] 
>> and it looks good. Thanks for another nice library.
>> You're welcome and we are pleased that you use it :-) 
>> 
>> My first question is about loading the code. I would like to load the 
>> minimum possible. I guess the stylesheet code is needed, but not the prism 
>> code ? 
>> You are totally right, Prism is required by the demo to display the code. 
>> You will not load it by using the 'core' group 
>> 
>> NeoJSON and Seaside are already in my project's dependencies, but Seaside3 
>> seems to never resolve to the same thing, so I would like to skip that. Is 
>> that possible ? I have this issue often with Seaside. I could fork and edit 
>> the baseline, but I'd rather not.
>> I have the same opinion, if you have a solution to manage it in a nice way i 
>> would be pleased to add it. I only see as a solution to create a group that 
>> do not load Seaside3 but maybe Cyril know a better way to do it (he is far 
>> better than me about baselines) 
>> 
>> I got a Bar chart on 2D data running right away.
>> 
>> But how can I use 'horizontalBar' as type ? 
>> 
>> var myBarChart = new Chart(ctx, {
>>    type: 'horizontalBar',
>>    data: data,
>>    options: options
>> });
>> 
>> I see that the types are encoded a classes, but the list seems rather 
>> limited.
>> We implemented the minimum that is required for us. It is really easy to add 
>> new ones as you already discovered. I will add these as soon as possible or 
>> if you already did it, create a pull request. There is many improvement that 
>> can be done in this project and it would be great to have your contribution 
>> about it.
>> 
>> We will move to the new version of the ChartJs library when we will have 
>> time to improve it. Of course the API of our project will stay the same and 
>> changes will not impact your project.
>> 
>> Thx,
>> 
>> Sven
>> 
>> 
>> 
>> 
>> -- 
>> Guillaume Larcheveque
>> 
> 


Reply via email to