Cool. Looks good. cheers -ben On Wed, Jun 7, 2017 at 2:20 AM, Stephane Ducasse <stepharo.s...@gmail.com> wrote:
> Hi ben > > Yes I changed it :) > Stef > > On Mon, May 29, 2017 at 10:16 AM, Ben Coman <b...@openinworld.com> wrote: > > On Mon, May 29, 2017 at 7:24 AM, horrido <horrido.hobb...@gmail.com> > wrote: > >> I don't use GitHub. I've never used GitHub. I don't know how to use > GitHub. > >> > >> I looked at making a pull request and I was totally stymied. "Clueless" > >> doesn't even begin to describe how I felt. > > > > Everyone starts there. Its a useful skill to have, so if you are > > interested to learn, here's a quickstart guide... > > (Note since its a text file, we are shortcutting so you don't even > > need git on your local machine) > > 1. Click on this link. > > https://github.com/SquareBracketAssociates/UpdatedPharoByExample/blob/ > master/Morphic/Morphic.pier > > 2. Click the <Fork> button in the top tight, then browse to > > "Morphic.pier" in your fork. > > 3. To the right of the <Raw/Blame/History> buttons, click the <Pencil> > > button to edit the file. > > 4. After editing, at the bottom select "Create a new branch for this > > commit and start a pull request" > > and enter commit title, comment and new-branch-name to reflect your > > contribution. Click <Propose file change> > > 5. Now looking at "Open a pull request", this is issuing a PR to your > > own fork. We need to change to the upstream fork. At the top click > > on "forked from SquareBracketAssociates/UpdatedPharoByExample" . > > 6. Under "Your recently pushed branches" click <Compare & pull request> > > 7. Check... > > base fork: SquareBracketAssociates/UpdatedPharoByExample > > base: master > > head fork: YourName/UpdatedPharoByExample > > compare: your new-branch-name > > Review the diff, enter PR title and comment, then click <Create pull > request>. > > > > If you have problems, try to catch me on Discord... > > https://discord.gg/dKv4qR/KCKQSSt > > > > cheers -ben > > > > P.S. @Stef, btw, it looks like "the guidelines for contributing" is > > out of date... > > https://github.com/SquareBracketAssociates/ > UpdatedPharoByExample/blob/master/CONTRIBUTING.md > > "This is a test to see if it makes sense to convert PharoByExample > > into pier format." > > > > > >> > >> > >> Ben Coman wrote > >>> On Sat, May 27, 2017 at 9:15 PM, horrido < > >> > >>> horrido.hobbies@ > >> > >>> > wrote: > >>>> Yes, I did. I found it difficult to understand. It would be nice to > have > >>>> some > >>>> clear examples in the documentation, for example, really simple and > >>>> common > >>>> situations such as a C function returning an integer in a > >>>> passed-by-reference argument. > >>>> > >>>> Speaking of documentation, in "Pharo by Example 50," I found this > >>>> statement: > >>>> > >>>>> (Recall that you should set halosEnabled in the Preferences > >>>> browser.) > >>>> > >>>> However, nowhere else in the book is there any reference to > halosEnabled > >>>> or > >>>> Preferences browser. > >>> > >>> Nice pick up. Now in Settings (in a fresh 60473 image), filtering on > >>> "halo" shows only: > >>> * Cycle both directions > >>> * Encloses fullbounds > >>> * Exhibits bounds > >>> so the comment seems irrelevant > >>> > >>> and #halosEnabled & #halosEnabled: each have one implementor > class-side of > >>> Morph > >>> with one sender from MorphTest each, and one sender from > Morph>>addHalo: > >>> > >>> and "Morph halosEnabled" ==> true, so the statement seems unnecessary. > >>> Would you like to contribute a pull request removing it? > >>> https://github.com/SquareBracketAssociates/UpdatedPharoByExample/blob/ > master/Morphic/Morphic.pier > >>> > >>> > >>>> Did you guys forget and leave out a chunk of the book? > >>> > >>> Its an evolutionary book originally from Squeak. It could well be > >>> that some parts of the book have been cleaned > >>> better than others to match Image changes. Thanks for reporting, and > >>> even better if you can correct it. > >>> > >>> cheers -ben > >> > >> > >> > >> > >> > >> -- > >> View this message in context: http://forum.world.st/How-to- > use-uFFI-with-String-tp4947890p4948512.html > >> Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com. > >> > > > >
