On 29-09-15 12:03, Carlo wrote:
This is one of those things where everyone has their personal opinions and probably not much payoff but anyway here are my thoughts. ShouldBeImplemented - this was supposed to be already implemented This is a stronger form of communication where some abstract behaviour should have been implemented. If this is received in code then this should be considered an error as a base class expects derived classes to have the behaviour or the class will not work as expected. NotYetImplemented - this will be implemented in very soon This is a weaker form of some missing behaviour. This is used to communicate that some behaviour has not been implemented yet, and it would be nice if it was but the rest of the object is still functional. If you'd like the behaviour either harass the owner or write it yourself. Sometime this usage is abused and developers create objects that are not polymorphic and typically break Liskov's Substitution Principle for example. So I would suggest keep the 2 as they communicate different ideas.
From a lean/agile perspective, NotYetImplemented is inventory that we try to eliminate from the system. There are lots of places in Pharo where we support doing 'the right thing' by steering with our tools. The most well known is of course the browser that makes it annoying to use long methods. I'd prefer NotYetImplemented to be removed.
Stephan
