> On 18 Aug 2015, at 22:39, Yuriy Tymchuk <yuriy.tymc...@me.com> wrote: > > This may have happened when I was removing contexts from the rules. >
I think the reason is that there was a cache in the context. But we need to check. > Uko > >> On 18 Aug 2015, at 18:25, stepharo <steph...@free.fr >> <mailto:steph...@free.fr>> wrote: >> >> Hi marcus >> >> do you get an idea why we got this slowdown? >> >> Stef >> >> Le 30/7/15 14:08, Marcus Denker a écrit : >>> I added an issue: >>> >>> https://pharo.fogbugz.com/f/cases/16074/Is-RBClassNotReferencedRule-200x-slower-in-Pharo-4-vs-Pharo-3 >>> >>> <https://pharo.fogbugz.com/f/cases/16074/Is-RBClassNotReferencedRule-200x-slower-in-Pharo-4-vs-Pharo-3> >>> >>> i think we need to put in some cashing… here if we would could all *used* >>> classes once for an enviroment…. >>> >>>> On 29 Jul 2015, at 17:33, Paul DeBruicker <pdebr...@gmail.com >>>> <mailto:pdebr...@gmail.com>> wrote: >>>> >>>> Paul DeBruicker wrote >>>>> Hi Stef, >>>>> >>>>> The slowdown is dependent upon the # of classes in the package. If you >>>>> use Fuel then you should see a slowdown of 20x. I just have a lot of >>>>> classes in this package. The source of the slowdown is in the changes to >>>>> RBSmallLintChecker>>#checkClass: and >>>>> RBClassNotReferencedRule>>#checkClass: . The old versions use the linter >>>>> to check if the literal is used anywhere and the new one uses #allCallsOn. >>>>> >>>>> >>>>> Hope this helps >>>>> >>>>> Paul >>>> >>>> >>>> and by "use Fuel" I mean: >>>> >>>> rule:=RBClassNotReferencedRule new. >>>> environment:=RBBrowserEnvironment new forPackageNames: #('Fuel'). >>>> >>>> >>>> AndreasSystemProfiler spyOn:[RBSmalllintChecker runRule: rule >>>> onEnvironment: >>>> environment] >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> -- >>>> View this message in context: >>>> http://forum.world.st/Is-RBClassNotReferencedRule-200x-slower-in-Pharo-4-vs-Pharo-3-tp4839875p4839977.html >>>> >>>> <http://forum.world.st/Is-RBClassNotReferencedRule-200x-slower-in-Pharo-4-vs-Pharo-3-tp4839875p4839977.html> >>>> Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com >>>> <http://nabble.com/>. >>>> >>> >> >
