Fixed and integrated (pharo 40350)
I'll open another issue for backporting to pharo3

2014-11-02 22:24 GMT+01:00 Nicolai Hess <nicolaih...@web.de>:

> Actually it is a bug in FileOUT!
>
> 14377 <https://pharo.fogbugz.com/default.asp?14377>
> FileOut creates invalid comment entries for classes with class side methods
>
>
> 2014-11-02 17:42 GMT+01:00 Nicolai Hess <nicolaih...@web.de>:
>
>> 2014-10-31 0:11 GMT+01:00 José Comesaña <jose.comes...@gmail.com>:
>>
>>> I see. But WATestError it is in the same package it is "Fileing", on
>>> line 3284 and is referenced many times before. I am sorry I have not enough
>>> knowledge about the internals to do more debugging.
>>>
>>> Seems to be a lack of coordination between FileOut and FileIn. Maybe
>>> nothing to do...
>>>
>>> Now a simpler and clearer test:
>>>
>>> 1. Back to the original situation.
>>> 2. FileOut *only* WAContextTest. It has a comment: "I am the base class
>>> for all tests that need a WARequestContext present.", in .st file in line 8.
>>> 3. Remove it.
>>> 4. FileIn again. No errors on Transcript BUT no comment appears for
>>> WAContextTest.
>>>
>>> Maybe, if I get a couple of free hours I could dare to debug a little....
>>>
>>> Best
>>>
>>>
>>> 2014-10-30 23:30 GMT+01:00 stepharo <steph...@free.fr>:
>>>
>>>>  It says that the class WATestError is not available.
>>>>
>>>>
>>>>
>>>>  Yes, I did. It is in the .st file
>>>>
>>>>
>>>>
>>>>> c. You get a bunch of errors in Transcript while filing in
>>>>>>
>>>>>  No magic ball so we cannot guess.
>>>>>
>>>>>
>>>>  Example of Transcript messages (in case it helps):
>>>> WADocumentHandlerResponseTest>>createAndVerifyBinaryDocumentNamed:hasAttachment:
>>>> (WATestingFiles is Undeclared)
>>>>
>>>>  WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is
>>>> Undeclared)
>>>>
>>>>  WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is
>>>> Undeclared)
>>>>
>>>>  WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is
>>>> Undeclared)
>>>>
>>>>  WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is
>>>> Undeclared)
>>>>
>>>>  WAExceptionHandlerTest>>testInternalError (WATestError is Undeclared)
>>>>
>>>>
>>>>  It happens in more cases. I just took this one because this is a
>>>> package anyone can install in order to reproduce the problem.
>>>>
>>>>  Thanks
>>>>
>>>>
>>>>
>>>
>>
>> Yes, it is a bug. Verified on Pharo4 with class ZnMessageBenchmark. The
>> class has a comment, after fileout/remove class/filein this class is
>> without a comment.
>> I'll open a bug report.
>>
>>
>

Reply via email to