Hi Jesus Mari,
Thanks for spotting and fixing those bugs. The missing methods are because I overrode them in a package I’m using and forgot about that when I saved some changes to iCal. I did not notice the problem with the timeZone because I’m in the habit of only using UTC dates and times in the image and converting them to timeZone specific formats for display. Good find. Re: #isValidForDate: I’m not sure about your solution. I think it depends on whether December 31st 2014 is the important part or whether the overlapping timespan of one date between two timezones is important. And to know that I’d have to read the ical spec. Which is here: http://tools.ietf.org/html/rfc5545 and I don’t have time to go through in any detail. Do you want/have write access to upload your repairs? Thanks again Paul On May 30, 2014, at 4:03 AM, Jesus Mari Aguirre <jmariagui...@gmail.com> wrote: > I have tried to run the Test package in Pharo 2.0 and I have found some > problems. > * You use String #subString method that is deprecated. > * There are several methods missed in your new packages, I'm not sure why... > ICConversion class #dateAndTimeClass, #dateClass, #timeSpanClass #timeClass. > I have added to the ICal-SqueakPharo-Core package copied from the first > version in the repository. > * methods ICEvent isValidForDate: aDate and ICTodo isValidForDate: aDate do > not take care about the timeZone, then several tests fail. These tests are > successful if you set the date offset to 0 hour, but maybe what you try to do > with the method is returning all the events and todos currently actives. > > Could be this method the right solution? > > ICEvent isValidForDate: aDate > > ^self start asDate start<= aDate end and: [self end asDate end>= aDate > start]. > > ICTodo isValidForDate: aDate > > ^self due asDate start<= aDate end and: [self due asDate end >= aDate > start]. > > I hope this information will be useful for you. > keep contact > Jesús Marí > >
