Bahman Movaqar wrote:
On 11/09/2013 12:23, b...@openinworld.com wrote:
  
Some minor nit-picks...

    
"please do so as we are going to iterate over what was done there."
      
I don't understand what you mean by 'iterate over'? Do you me 'build on'?
    
Yes, that's what I meant: "improve".  If you find it hard to understand,
let me know.
  
Okay. You should use 'build on'.


  
* Regarding #defaultSpec, I happen to like what is used in PharoLauncher
   specLayout
       <spec: #default>
       ^ SpecLayout composed  ...etc
    
I don't understand your point.  Could you elaborate a bit more on this?
  
That comment wasn't aimed at yourself, but to explain further...
I am not so familiar with Spec, but it would seem there are two ways to define the default layout:
* defining the #defaultSpec method; or
* adding the <spec: #default> pragma to one method.

I'm not really sure of the tradeoffs between the two, but I think I liked the second simply because the word 'Layout' could appear in the method name.  I'm not sure if that way of thinking is misplaced, but just based on my current understanding.
Actually thinking about it some more, I wonder what would happen in two methods included the <spec: #default> pragma?  This seems something that might not be immediately apparent without an exhaustive search through methods. 

Also, are pragmas inherited? 
For example, if class A has method #defaultSpec, with (A subclass: B) then class B would still open with the same layout.
However if class A has no #defaultSpec method but instead the <spec: #default> pragma, would class B still open with the same layout?
I know I could just try it out myself, but I am interested in any wider implications people can think of.

cheers -ben


Reply via email to