Hi,

Sometimes it happens that a *description* of a fix is added to the issue 
tracker entry.

We try to tag them with “Fix Proposed"

https://github.com/pharo-project/pharo/labels/Fix%20proposed 
<https://github.com/pharo-project/pharo/labels/Fix%20proposed>


In practice, it is either astonishingly hard to turn a description into a fix, 
or it is so trivial that 
it feels as if nothing has to be done. (It feels sometimes that finding the 
solution is the
real contribution, while actually doing it feels like boring work).

- add, if possible, the code of the whole changed method, too
        (I often wonder if it is all correct after doing the steps described by 
a textual description, 
        especially if the method got changed in between)

- Make it *really* clear in the issue tracker entry that a fix has been 
proposed.
        Sometimes it gets lost in the discussion.

- Doing a PR from an issue that already has a description is very valuable
        This can a nice way to contribute for beginners. 
        “It don’t understand if it is good, but I made a PR for the solution 
described in the issue" 


        Marcus

Reply via email to