Agreed. I'll do the rework and send a pull-request when it's finished.
On 5/21/21 6:23 PM, ducasse wrote:
Thanks.
I do not think that it is good to reintroduce this super ugly class.
at the minimum it should be in a separate branch.
S
On 21 May 2021, at 18:06, Günter Khyo via Pharo-dev
<[email protected] <mailto:[email protected]>> wrote:
Hi Stef,
Great! I'll send you a pull-request for the "hotfix" this evening. As
I mentioned to Sven, I'll do some rework on the implementation and
documentation when I find the time.
Günter
On 5/21/21 5:55 PM, ducasse wrote:
I checked and all the tests pass on Pharo80.
Now I did a little pass on the tests.
I do not have the time to migrate this lib to P9.
But I would accept Pull Requests :)
S.
On 21 May 2021, at 17:46, ducasse <[email protected]
<mailto:[email protected]>> wrote:
The old travis was telling that the code works in 6.1, 7 and 8.0
I added GithubActions for Pharo 80 and I will see.
S
On 21 May 2021, at 17:40, ducasse <[email protected]
<mailto:[email protected]>> wrote:
Hi gunter
I’m maintaining OSC
https://github.com/Ducasse/OSC
and TUIO
https://github.com/Ducasse/TUIO
Please do some PR if something does not work.
S
On 21 May 2021, at 14:02, Günter Khyo via Pharo-dev
<[email protected] <mailto:[email protected]>> wrote:
Hi,
I have ported the Open Sound Control package to Pharo 9.0. Since
the Catalog Browser is marked as legacy, I was wondering how to
submit the patch. Is there a git repository? I attached the
fileout to this email in case anybody wants to take a look at the
package or knows how/where to add it to Pharo 9.0,
Patch Note:
OSC relies on the removed /RWTextOrBinaryStream/ class which has
very specific behavior that I could not emulate using the
available stream and codec classes, so I pulled in the class from
Squeak 5, renamed it to OSCStream and added it to the OSC
package. This seemed to be the easiest way to do it without
changing the OSC implementation, but I welcome any suggestions
for a cleaner solution.
Günter
<OSC.st <http://osc.st/>>
