Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Magnus Hagander wrote: > >> I think that's backwards. We *are* passing them by reference, we should > >> be considering passing them by value. > > > Thanks, fixed. > > Also, the TODO item ought to mention float4 and float8, which IMHO ought > to be changed at the same time. float4 could become pass-by-val-always. > I think the main reason we've avoided that is to avoid breaking old code > that is not using DatumGet/GetDatum macros, but we'll be breaking most > such code anyway with this set of changes.
Update: * Consider allowing 64-bit integers and floats to be passed by value on 64-bit platforms Also change 32-bit floats (float4) to be passed by value at the same time. -- Bruce Momjian <[EMAIL PROTECTED]> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---------------------------(end of broadcast)--------------------------- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly